Commitbb513b3

committed

Get rid of unnecessary memory allocation in jsonb_subscript_assign()

Current code allocates memory for JsonbValue, but it could be placed locally.

1 parentfe61df7 commitbb513b3Copy full SHA for bb513b3

File tree

-7

lines changed

-7

lines changed

Lines changed: 7 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -283,7 +283,7 @@ jsonb_subscript_assign(ExprState *state,`
`283`	`283`	`*/`
`284`	`284`	`if (*op->resnull)`
`285`	`285`	`{`
`286`		`-JsonbValuenewSource= (JsonbValue)palloc(sizeof(JsonbValue));`
	`286`	`+JsonbValuenewSource;`
`287`	`287`
`288`	`288`	`/*`
`289`	`289`	`* To avoid any surprising results, set up an empty jsonb array in`
`@@ -292,17 +292,17 @@ jsonb_subscript_assign(ExprState *state,`
`292`	`292`	`*/`
`293`	`293`	`if (workspace->expectArray)`
`294`	`294`	`{`
`295`		`-newSource->type=jbvArray;`
`296`		`-newSource->val.array.nElems=0;`
`297`		`-newSource->val.array.rawScalar= false;`
	`295`	`+newSource.type=jbvArray;`
	`296`	`+newSource.val.array.nElems=0;`
	`297`	`+newSource.val.array.rawScalar= false;`
`298`	`298`	`}`
`299`	`299`	`else`
`300`	`300`	`{`
`301`		`-newSource->type=jbvObject;`
`302`		`-newSource->val.object.nPairs=0;`
	`301`	`+newSource.type=jbvObject;`
	`302`	`+newSource.val.object.nPairs=0;`
`303`	`303`	`}`
`304`	`304`
`305`		`-jsonbSource=JsonbValueToJsonb(newSource);`
	`305`	`+jsonbSource=JsonbValueToJsonb(&newSource);`
`306`	`306`	`*op->resnull= false;`
`307`	`307`	`}`
`308`	`308`	`else`

Comments

(0)