NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitbac9947

committed

Stabilize results of brin regression test.

This test used seqscans on tenk1, with LIMIT, to build test data.That works most of the time, but if the synchronized-seqscan logickicks in, we get varying test data. This seems likely to explainthe erratic test failures on buildfarm member chipmunk, which usessmaller-than-default shared_buffers. To fix, add ORDER BY clauses toforce the ordering to be what it was implicitly being assumed to be.Peter Geoghegan had noticed this with respect to one of the troublespots, though not the ones actually causing the chipmunk issue.

1 parent5cdf25e commitbac9947Copy full SHA for bac9947

File tree

2 files changed

-6

lines changed

src/test/regress
- expected
  - brin.out
- sql
  - brin.sql

2 files changed

-6

lines changed

`‎src/test/regress/expected/brin.out`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -55,13 +55,13 @@ INSERT INTO brintest SELECT`
`55`	`55`	`int4range(thousand, twothousand),`
`56`	`56`	`format('%s/%s%s', odd, even, tenthous)::pg_lsn,`
`57`	`57`	`box(point(odd, even), point(thousand, twothousand))`
`58`		`-FROM tenk1 LIMIT 100;`
	`58`	`+FROM tenk1ORDER BY unique2LIMIT 100;`
`59`	`59`	`-- throw in some NULL's and different values`
`60`	`60`	`INSERT INTO brintest (inetcol, cidrcol, int4rangecol) SELECT`
`61`	`61`	`inet 'fe80::6e40:8ff:fea9:8c46' + tenthous,`
`62`	`62`	`cidr 'fe80::6e40:8ff:fea9:8c46' + tenthous,`
`63`	`63`	`'empty'::int4range`
`64`		`-FROM tenk1 LIMIT 25;`
	`64`	`+FROM tenk1ORDER BY thousand, tenthousLIMIT 25;`
`65`	`65`	`CREATE INDEX brinidx ON brintest USING brin (`
`66`	`66`	`byteacol,`
`67`	`67`	`charcol,`
`@@ -238,7 +238,7 @@ INSERT INTO brintest SELECT`
`238`	`238`	`int4range(thousand, twothousand),`
`239`	`239`	`format('%s/%s%s', odd, even, tenthous)::pg_lsn,`
`240`	`240`	`box(point(odd, even), point(thousand, twothousand))`
`241`		`-FROM tenk1 LIMIT 5 OFFSET 5;`
	`241`	`+FROM tenk1ORDER BY unique2LIMIT 5 OFFSET 5;`
`242`	`242`	`VACUUM brintest; -- force a summarization cycle in brinidx`
`243`	`243`	`UPDATE brintest SET int8col = int8col * int4col;`
`244`	`244`	`UPDATE brintest SET textcol = '' WHERE textcol IS NOT NULL;`

`‎src/test/regress/sql/brin.sql`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -56,14 +56,14 @@ INSERT INTO brintest SELECT`
`56`	`56`	`int4range(thousand, twothousand),`
`57`	`57`	`format('%s/%s%s', odd, even, tenthous)::pg_lsn,`
`58`	`58`	`box(point(odd, even),point(thousand, twothousand))`
`59`		`-FROM tenk1LIMIT100;`
	`59`	`+FROM tenk1ORDER BY unique2LIMIT100;`
`60`	`60`
`61`	`61`	`-- throw in some NULL's and different values`
`62`	`62`	`INSERT INTO brintest (inetcol, cidrcol, int4rangecol)SELECT`
`63`	`63`	`inet'fe80::6e40:8ff:fea9:8c46'+ tenthous,`
`64`	`64`	`cidr'fe80::6e40:8ff:fea9:8c46'+ tenthous,`
`65`	`65`	`'empty'::int4range`
`66`		`-FROM tenk1LIMIT25;`
	`66`	`+FROM tenk1ORDER BY thousand, tenthousLIMIT25;`
`67`	`67`
`68`	`68`	`CREATEINDEXbrinidxON brintest USING brin (`
`69`	`69`	`byteacol,`
`@@ -245,7 +245,7 @@ INSERT INTO brintest SELECT`
`245`	`245`	`int4range(thousand, twothousand),`
`246`	`246`	`format('%s/%s%s', odd, even, tenthous)::pg_lsn,`
`247`	`247`	`box(point(odd, even),point(thousand, twothousand))`
`248`		`-FROM tenk1LIMIT5 OFFSET5;`
	`248`	`+FROM tenk1ORDER BY unique2LIMIT5 OFFSET5;`
`249`	`249`
`250`	`250`	`VACUUM brintest;-- force a summarization cycle in brinidx`
`251`	`251`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitbac9947

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/brin.out`

`‎src/test/regress/sql/brin.sql`

0 commit comments