Commitba19a6b

committed

Fix error reporting of connect_timeout in libpq for value parsing

The logic was correctly detecting a parsing failure, but the parsingerror did not get reported back to the client properly.Reported-by: Ed MorleyAuthor: Lars KanisReviewed-by: Michael PaquierDiscussion:https://postgr.es/m/a9b4cbd7-4ecb-06b2-ebd7-1739bbff3217@greiz-reinsdorf.deBackpatch-through: 12

1 parent4f4061b commitba19a6bCopy full SHA for ba19a6b

File tree

-0

lines changed

-0

lines changed

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2025,7 +2025,11 @@ connectDBComplete(PGconn *conn)`
`2025`	`2025`	`{`
`2026`	`2026`	`if (!parse_int_param(conn->connect_timeout,&timeout,conn,`
`2027`	`2027`	`"connect_timeout"))`
	`2028`	`+{`
	`2029`	`+/* mark the connection as bad to report the parsing failure */`
	`2030`	`+conn->status=CONNECTION_BAD;`
`2028`	`2031`	`return0;`
	`2032`	`+}`
`2029`	`2033`
`2030`	`2034`	`if (timeout>0)`
`2031`	`2035`	`{`

Comments

(0)