forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commitba0da16
committed
Require callers of coerce_to_domain() to supply base type/typmod.
In view of the issue fixed in commit0da39aa, it no longer seemslike a great idea for coerce_to_domain() to offer to perform a lookupthat its caller probably should have done already. The caller shouldbe providing a value of the domain's base type, so it's hard toenvision a valid case where it hasn't looked up that type. After0da39aa there is only one caller using the option for internallookup, and that one can trivially be rearranged to not do that.So this seems more like a bug-encouraging misfeature than a usefulshortcut; let's get rid of it (in HEAD only, there's no need tobreak any external callers in back branches).Discussion:https://postgr.es/m/1865579.1738113656@sss.pgh.pa.us1 parent0da39aa commitba0da16
1 file changed
+12
-14
lines changedLines changed: 12 additions & 14 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
414 | 414 |
| |
415 | 415 |
| |
416 | 416 |
| |
| 417 | + | |
| 418 | + | |
| 419 | + | |
| 420 | + | |
| 421 | + | |
| 422 | + | |
417 | 423 |
| |
418 | 424 |
| |
419 | 425 |
| |
| |||
423 | 429 |
| |
424 | 430 |
| |
425 | 431 |
| |
426 |
| - | |
427 |
| - | |
428 |
| - | |
429 |
| - | |
430 |
| - | |
431 |
| - | |
432 | 432 |
| |
433 | 433 |
| |
434 | 434 |
| |
| |||
454 | 454 |
| |
455 | 455 |
| |
456 | 456 |
| |
457 |
| - | |
| 457 | + | |
| 458 | + | |
458 | 459 |
| |
459 | 460 |
| |
460 | 461 |
| |
| |||
660 | 661 |
| |
661 | 662 |
| |
662 | 663 |
| |
663 |
| - | |
664 |
| - | |
665 |
| - | |
666 |
| - | |
| 664 | + | |
| 665 | + | |
667 | 666 |
| |
668 | 667 |
| |
669 | 668 |
| |
| |||
679 | 678 |
| |
680 | 679 |
| |
681 | 680 |
| |
682 |
| - | |
683 |
| - | |
684 |
| - | |
| 681 | + | |
| 682 | + | |
685 | 683 |
| |
686 | 684 |
| |
687 | 685 |
| |
|
0 commit comments
Comments
(0)