forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commitb9bffa0
committed
ANALYZE a_star and its children to avoid plan instability in tests.
We've noted certain EXPLAIN queries on these tables occasionally showingunexpected plan choices. This seems to happen because VACUUM sometimesfails to update relpages/reltuples for one of these single-page tables,due to bgwriter or checkpointer holding a pin on the lone page at justthe wrong time. To ensure those values get set, insert explicit ANALYZEoperations on these tables after we finish populating them. Thisdoesn't seem to affect any other test cases, so it's a usable fix.Back-patch to v12. In principle the issue exists further back, butwe have not seen it before v12, so I won't risk back-patching further.Discussion:https://postgr.es/m/24480.1569518042@sss.pgh.pa.us1 parentd9cacca commitb9bffa0
2 files changed
+15
-0
lines changedLines changed: 7 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
130 | 130 |
| |
131 | 131 |
| |
132 | 132 |
| |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
133 | 140 |
| |
134 | 141 |
| |
135 | 142 |
| |
|
Lines changed: 8 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
192 | 192 |
| |
193 | 193 |
| |
194 | 194 |
| |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
195 | 203 |
| |
196 | 204 |
| |
197 | 205 |
| |
|
0 commit comments
Comments
(0)