Commitb98fd52

committed

Silence -Wunused-result warning in contrib/pg_upgrade.

This is just neatnik-ism, but since we do it for comparable code in elog.c,we may as well do it here.

1 parentaa2b237 commitb98fd52Copy full SHA for b98fd52

File tree

+10

-2

lines changed

+10

-2

lines changed

Lines changed: 10 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -81,10 +81,18 @@ pg_log(eLogType type, char *fmt,...)`
`81`	`81`	`/* fopen() on log_opts.internal might have failed, so check it */`
`82`	`82`	`if ((type!=PG_VERBOSE\|\|log_opts.verbose)&&log_opts.internal!=NULL)`
`83`	`83`	`{`
`84`		`-fwrite(message,strlen(message),1,log_opts.internal);`
	`84`	`+/*`
	`85`	`+ * There's nothing much we can do about it if fwrite fails, but some`
	`86`	`+ * platforms declare fwrite with warn_unused_result. Do a little`
	`87`	`+ * dance with casting to void to shut up the compiler in such cases.`
	`88`	`+ */`
	`89`	`+size_trc;`
	`90`	`+`
	`91`	`+rc=fwrite(message,strlen(message),1,log_opts.internal);`
`85`	`92`	`/* if we are using OVERWRITE_MESSAGE, add newline to log file */`
`86`	`93`	`if (strchr(message,'\r')!=NULL)`
`87`		`-fwrite("\n",1,1,log_opts.internal);`
	`94`	`+rc=fwrite("\n",1,1,log_opts.internal);`
	`95`	`+(void)rc;`
`88`	`96`	`fflush(log_opts.internal);`
`89`	`97`	`}`
`90`	`98`

Comments

(0)