Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitb8a1247

Browse files
committed
Fix INSERT ON CONFLICT UPDATE through a view that isn't just SELECT *.
When expanding an updatable view that is an INSERT's target, the rewriterfailed to rewrite Vars in the ON CONFLICT UPDATE clause. This accidentallyworked if the view was just "SELECT * FROM ...", as the transformationwould be a no-op in that case. With more complicated view targetlists,this omission would often lead to "attribute ... has the wrong type" errorsor even crashes, as reported by Mario De Frutos Dieguez.Fix by adding code to rewriteTargetView to fix up the data structurecorrectly. The easiest way to update the exclRelTlist list is to rebuildit from scratch looking at the new target relation, so factor the codefor that out of transformOnConflictClause to make it sharable.In passing, avoid duplicate permissions checks against the EXCLUDEDpseudo-relation, and prevent useless view expansion of that relation'sdummy RTE. The latter is only known to happen (after this patch) in caseswhere the query would fail later due to not having any INSTEAD OF triggersfor the view. But by exactly that token, it would create an unintendedand very poorly tested state of the query data structure, so it seems likea good idea to prevent it from happening at all.This has been broken since ON CONFLICT was introduced, so back-patchto 9.5.Dean Rasheed, based on an earlier patch by Amit Langote;comment-kibitzing and back-patching by meDiscussion:https://postgr.es/m/CAFYwGJ0xfzy8jaK80hVN2eUWr6huce0RU8AgU04MGD00igqkTg@mail.gmail.com
1 parent5a23c74 commitb8a1247

File tree

5 files changed

+514
-57
lines changed

5 files changed

+514
-57
lines changed

‎src/backend/parser/analyze.c

Lines changed: 81 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -1022,9 +1022,6 @@ transformOnConflictClause(ParseState *pstate,
10221022
if (onConflictClause->action==ONCONFLICT_UPDATE)
10231023
{
10241024
Relationtargetrel=pstate->p_target_relation;
1025-
Var*var;
1026-
TargetEntry*te;
1027-
intattno;
10281025

10291026
/*
10301027
* All INSERT expressions have been parsed, get ready for potentially
@@ -1033,75 +1030,36 @@ transformOnConflictClause(ParseState *pstate,
10331030
pstate->p_is_insert= false;
10341031

10351032
/*
1036-
* Add range table entry for the EXCLUDED pseudo relation; relkind is
1033+
* Add range table entry for the EXCLUDED pseudo relation. relkind is
10371034
* set to composite to signal that we're not dealing with an actual
1038-
* relation.
1035+
* relation, and no permission checks are required on it. (We'll
1036+
* check the actual target relation, instead.)
10391037
*/
10401038
exclRte=addRangeTableEntryForRelation(pstate,
10411039
targetrel,
10421040
makeAlias("excluded",NIL),
10431041
false, false);
10441042
exclRte->relkind=RELKIND_COMPOSITE_TYPE;
1045-
exclRelIndex=list_length(pstate->p_rtable);
1046-
1047-
/*
1048-
* Build a targetlist representing the columns of the EXCLUDED pseudo
1049-
* relation. Have to be careful to use resnos that correspond to
1050-
* attnos of the underlying relation.
1051-
*/
1052-
for (attno=0;attno<RelationGetNumberOfAttributes(targetrel);attno++)
1053-
{
1054-
Form_pg_attributeattr=TupleDescAttr(targetrel->rd_att,attno);
1055-
char*name;
1056-
1057-
if (attr->attisdropped)
1058-
{
1059-
/*
1060-
* can't use atttypid here, but it doesn't really matter what
1061-
* type the Const claims to be.
1062-
*/
1063-
var= (Var*)makeNullConst(INT4OID,-1,InvalidOid);
1064-
name="";
1065-
}
1066-
else
1067-
{
1068-
var=makeVar(exclRelIndex,attno+1,
1069-
attr->atttypid,attr->atttypmod,
1070-
attr->attcollation,
1071-
0);
1072-
name=pstrdup(NameStr(attr->attname));
1073-
}
1043+
exclRte->requiredPerms=0;
1044+
/* other permissions fields in exclRte are already empty */
10741045

1075-
te=makeTargetEntry((Expr*)var,
1076-
attno+1,
1077-
name,
1078-
false);
1079-
1080-
/* don't require select access yet */
1081-
exclRelTlist=lappend(exclRelTlist,te);
1082-
}
1046+
exclRelIndex=list_length(pstate->p_rtable);
10831047

1084-
/*
1085-
* Add a whole-row-Var entry to support references to "EXCLUDED.*".
1086-
* Like the other entries in exclRelTlist, its resno must match the
1087-
* Var's varattno, else the wrong things happen while resolving
1088-
* references in setrefs.c. This is against normal conventions for
1089-
* targetlists, but it's okay since we don't use this as a real tlist.
1090-
*/
1091-
var=makeVar(exclRelIndex,InvalidAttrNumber,
1092-
targetrel->rd_rel->reltype,
1093-
-1,InvalidOid,0);
1094-
te=makeTargetEntry((Expr*)var,InvalidAttrNumber,NULL, true);
1095-
exclRelTlist=lappend(exclRelTlist,te);
1048+
/* Create EXCLUDED rel's targetlist for use by EXPLAIN */
1049+
exclRelTlist=BuildOnConflictExcludedTargetlist(targetrel,
1050+
exclRelIndex);
10961051

10971052
/*
10981053
* Add EXCLUDED and the target RTE to the namespace, so that they can
1099-
* be used in the UPDATEstatement.
1054+
* be used in the UPDATEsubexpressions.
11001055
*/
11011056
addRTEtoQuery(pstate,exclRte, false, true, true);
11021057
addRTEtoQuery(pstate,pstate->p_target_rangetblentry,
11031058
false, true, true);
11041059

1060+
/*
1061+
* Now transform the UPDATE subexpressions.
1062+
*/
11051063
onConflictSet=
11061064
transformUpdateTargetList(pstate,onConflictClause->targetList);
11071065

@@ -1126,6 +1084,74 @@ transformOnConflictClause(ParseState *pstate,
11261084
}
11271085

11281086

1087+
/*
1088+
* BuildOnConflictExcludedTargetlist
1089+
*Create target list for the EXCLUDED pseudo-relation of ON CONFLICT,
1090+
*representing the columns of targetrel with varno exclRelIndex.
1091+
*
1092+
* Note: Exported for use in the rewriter.
1093+
*/
1094+
List*
1095+
BuildOnConflictExcludedTargetlist(Relationtargetrel,
1096+
IndexexclRelIndex)
1097+
{
1098+
List*result=NIL;
1099+
intattno;
1100+
Var*var;
1101+
TargetEntry*te;
1102+
1103+
/*
1104+
* Note that resnos of the tlist must correspond to attnos of the
1105+
* underlying relation, hence we need entries for dropped columns too.
1106+
*/
1107+
for (attno=0;attno<RelationGetNumberOfAttributes(targetrel);attno++)
1108+
{
1109+
Form_pg_attributeattr=TupleDescAttr(targetrel->rd_att,attno);
1110+
char*name;
1111+
1112+
if (attr->attisdropped)
1113+
{
1114+
/*
1115+
* can't use atttypid here, but it doesn't really matter what type
1116+
* the Const claims to be.
1117+
*/
1118+
var= (Var*)makeNullConst(INT4OID,-1,InvalidOid);
1119+
name="";
1120+
}
1121+
else
1122+
{
1123+
var=makeVar(exclRelIndex,attno+1,
1124+
attr->atttypid,attr->atttypmod,
1125+
attr->attcollation,
1126+
0);
1127+
name=pstrdup(NameStr(attr->attname));
1128+
}
1129+
1130+
te=makeTargetEntry((Expr*)var,
1131+
attno+1,
1132+
name,
1133+
false);
1134+
1135+
result=lappend(result,te);
1136+
}
1137+
1138+
/*
1139+
* Add a whole-row-Var entry to support references to "EXCLUDED.*". Like
1140+
* the other entries in the EXCLUDED tlist, its resno must match the Var's
1141+
* varattno, else the wrong things happen while resolving references in
1142+
* setrefs.c. This is against normal conventions for targetlists, but
1143+
* it's okay since we don't use this as a real tlist.
1144+
*/
1145+
var=makeVar(exclRelIndex,InvalidAttrNumber,
1146+
targetrel->rd_rel->reltype,
1147+
-1,InvalidOid,0);
1148+
te=makeTargetEntry((Expr*)var,InvalidAttrNumber,NULL, true);
1149+
result=lappend(result,te);
1150+
1151+
returnresult;
1152+
}
1153+
1154+
11291155
/*
11301156
* count_rowexpr_columns -
11311157
* get number of columns contained in a ROW() expression;

‎src/backend/rewrite/rewriteHandler.c

Lines changed: 101 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
#include"nodes/nodeFuncs.h"
3030
#include"parser/analyze.h"
3131
#include"parser/parse_coerce.h"
32+
#include"parser/parse_relation.h"
3233
#include"parser/parsetree.h"
3334
#include"rewrite/rewriteDefine.h"
3435
#include"rewrite/rewriteHandler.h"
@@ -1770,6 +1771,17 @@ fireRIRrules(Query *parsetree, List *activeRIRs)
17701771
if (rte->relkind==RELKIND_MATVIEW)
17711772
continue;
17721773

1774+
/*
1775+
* In INSERT ... ON CONFLICT, ignore the EXCLUDED pseudo-relation;
1776+
* even if it points to a view, we needn't expand it, and should not
1777+
* because we want the RTE to remain of RTE_RELATION type. Otherwise,
1778+
* it would get changed to RTE_SUBQUERY type, which is an
1779+
* untested/unsupported situation.
1780+
*/
1781+
if (parsetree->onConflict&&
1782+
rt_index==parsetree->onConflict->exclRelIndex)
1783+
continue;
1784+
17731785
/*
17741786
* If the table is not referenced in the query, then we ignore it.
17751787
* This prevents infinite expansion loop due to new rtable entries
@@ -2875,8 +2887,6 @@ rewriteTargetView(Query *parsetree, Relation view)
28752887
*/
28762888
base_rte->relkind=base_rel->rd_rel->relkind;
28772889

2878-
heap_close(base_rel,NoLock);
2879-
28802890
/*
28812891
* If the view query contains any sublink subqueries then we need to also
28822892
* acquire locks on any relations they refer to. We know that there won't
@@ -3034,6 +3044,93 @@ rewriteTargetView(Query *parsetree, Relation view)
30343044
}
30353045
}
30363046

3047+
/*
3048+
* For INSERT .. ON CONFLICT .. DO UPDATE, we must also update assorted
3049+
* stuff in the onConflict data structure.
3050+
*/
3051+
if (parsetree->onConflict&&
3052+
parsetree->onConflict->action==ONCONFLICT_UPDATE)
3053+
{
3054+
Indexold_exclRelIndex,
3055+
new_exclRelIndex;
3056+
RangeTblEntry*new_exclRte;
3057+
List*tmp_tlist;
3058+
3059+
/*
3060+
* Like the INSERT/UPDATE code above, update the resnos in the
3061+
* auxiliary UPDATE targetlist to refer to columns of the base
3062+
* relation.
3063+
*/
3064+
foreach(lc,parsetree->onConflict->onConflictSet)
3065+
{
3066+
TargetEntry*tle= (TargetEntry*)lfirst(lc);
3067+
TargetEntry*view_tle;
3068+
3069+
if (tle->resjunk)
3070+
continue;
3071+
3072+
view_tle=get_tle_by_resno(view_targetlist,tle->resno);
3073+
if (view_tle!=NULL&& !view_tle->resjunk&&IsA(view_tle->expr,Var))
3074+
tle->resno= ((Var*)view_tle->expr)->varattno;
3075+
else
3076+
elog(ERROR,"attribute number %d not found in view targetlist",
3077+
tle->resno);
3078+
}
3079+
3080+
/*
3081+
* Also, create a new RTE for the EXCLUDED pseudo-relation, using the
3082+
* query's new base rel (which may well have a different column list
3083+
* from the view, hence we need a new column alias list). This should
3084+
* match transformOnConflictClause. In particular, note that the
3085+
* relkind is set to composite to signal that we're not dealing with
3086+
* an actual relation, and no permissions checks are wanted.
3087+
*/
3088+
old_exclRelIndex=parsetree->onConflict->exclRelIndex;
3089+
3090+
new_exclRte=addRangeTableEntryForRelation(make_parsestate(NULL),
3091+
base_rel,
3092+
makeAlias("excluded",
3093+
NIL),
3094+
false, false);
3095+
new_exclRte->relkind=RELKIND_COMPOSITE_TYPE;
3096+
new_exclRte->requiredPerms=0;
3097+
/* other permissions fields in new_exclRte are already empty */
3098+
3099+
parsetree->rtable=lappend(parsetree->rtable,new_exclRte);
3100+
new_exclRelIndex=parsetree->onConflict->exclRelIndex=
3101+
list_length(parsetree->rtable);
3102+
3103+
/*
3104+
* Replace the targetlist for the EXCLUDED pseudo-relation with a new
3105+
* one, representing the columns from the new base relation.
3106+
*/
3107+
parsetree->onConflict->exclRelTlist=
3108+
BuildOnConflictExcludedTargetlist(base_rel,new_exclRelIndex);
3109+
3110+
/*
3111+
* Update all Vars in the ON CONFLICT clause that refer to the old
3112+
* EXCLUDED pseudo-relation. We want to use the column mappings
3113+
* defined in the view targetlist, but we need the outputs to refer to
3114+
* the new EXCLUDED pseudo-relation rather than the new target RTE.
3115+
* Also notice that "EXCLUDED.*" will be expanded using the view's
3116+
* rowtype, which seems correct.
3117+
*/
3118+
tmp_tlist=copyObject(view_targetlist);
3119+
3120+
ChangeVarNodes((Node*)tmp_tlist,new_rt_index,
3121+
new_exclRelIndex,0);
3122+
3123+
parsetree->onConflict= (OnConflictExpr*)
3124+
ReplaceVarsFromTargetList((Node*)parsetree->onConflict,
3125+
old_exclRelIndex,
3126+
0,
3127+
view_rte,
3128+
tmp_tlist,
3129+
REPLACEVARS_REPORT_ERROR,
3130+
0,
3131+
&parsetree->hasSubLinks);
3132+
}
3133+
30373134
/*
30383135
* For UPDATE/DELETE, pull up any WHERE quals from the view. We know that
30393136
* any Vars in the quals must reference the one base relation, so we need
@@ -3161,6 +3258,8 @@ rewriteTargetView(Query *parsetree, Relation view)
31613258
}
31623259
}
31633260

3261+
heap_close(base_rel,NoLock);
3262+
31643263
returnparsetree;
31653264
}
31663265

‎src/include/parser/analyze.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,7 @@ extern void applyLockingClause(Query *qry, Index rtindex,
4343
LockClauseStrengthstrength,
4444
LockWaitPolicywaitPolicy,boolpushedDown);
4545

46+
externList*BuildOnConflictExcludedTargetlist(Relationtargetrel,
47+
IndexexclRelIndex);
48+
4649
#endif/* ANALYZE_H */

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp