forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commitb898eb6
committed
Remove option to write USING before opclass name in CREATE INDEX.
Dating back to commitf10b639, our grammar has allowed "USING" tooptionally appear before an opclass name in CREATE INDEX (and, lately,some related places such as ON CONFLICT specifications). Nikolay Shaplovnoticed that this syntax existed but wasn't documented, and proposeddocumenting it. But what seems like a better idea is to remove theproduction, thereby making the code match the docs not vice versa.This isn't our usual modus operandi for such cases, but there are acouple of good reasons to proceed this way:* So far as I can find, this syntax has never been documented anywhere.It isn't relied on by any of our own code or test cases, and there seemslittle reason to suppose that it's been used in the wild either.* Documenting it would mean that there would be two separate uses ofUSING in the CREATE INDEX syntax, the other being "USING access_method".That can lead to nothing but confusion.So, let's just remove it. On the off chance that somebody somewhereis using it, this isn't something to back-patch, but we can fix itin HEAD.Discussion: <1593237.l7oKHRpxSe@nataraj-amd64>1 parent52e8fc3 commitb898eb6
1 file changed
+0
-1
lines changedLines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6747 | 6747 | | |
6748 | 6748 | | |
6749 | 6749 | | |
6750 | | - | |
6751 | 6750 | | |
6752 | 6751 | | |
6753 | 6752 | | |
| |||
0 commit comments
Comments
(0)