Movatterモバイル変換

Skip to content

postgrespro/postgresPublic

forked frompostgres/postgres

NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitb87671f

bmomjian

committed

Shorten warning about hash creation

Also document that PITR is also affected.

1 parent417f924 commitb87671fCopy full SHA for b87671f

File tree

7 files changed

+11

-10

lines changed

doc/src/sgml/ref
- create_index.sgml
src
- backend/commands
  - indexcmds.c
- test/regress/expected

7 files changed

+11

-10

lines changed

`‎doc/src/sgml/ref/create_index.sgml`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -474,7 +474,8 @@ Indexes:`
`474`	`474`	`Also, changes to hash indexes are not replicated over streaming or`
`475`	`475`	`file-based replication after the initial base backup, so they`
`476`	`476`	`give wrong answers to queries that subsequently use them.`
`477`		`- For these reasons, hash index use is presently discouraged.`
	`477`	`+ Hash indexes are also not properly restored during point-in-time`
	`478`	`+ recovery. For these reasons, hash index use is presently discouraged.`
`478`	`479`	`</para>`
`479`	`480`	`</caution>`
`480`	`481`

`‎src/backend/commands/indexcmds.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -491,7 +491,7 @@ DefineIndex(Oid relationId,`
`491`	`491`
`492`	`492`	`if (strcmp(accessMethodName,"hash")==0)`
`493`	`493`	`ereport(WARNING,`
`494`		`-(errmsg("hash indexes are not WAL-logged andthus are not crash-safe and cannot be used on standby servers")));`
	`494`	`+(errmsg("hash indexes are not WAL-logged andtheir use is discouraged")));`
`495`	`495`
`496`	`496`	`if (stmt->unique&& !accessMethodForm->amcanunique)`
`497`	`497`	`ereport(ERROR,`

`‎src/test/regress/expected/create_index.out`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -2238,13 +2238,13 @@ DROP TABLE array_gin_test;`
`2238`	`2238`	`-- HASH`
`2239`	`2239`	`--`
`2240`	`2240`	`CREATE INDEX hash_i4_index ON hash_i4_heap USING hash (random int4_ops);`
`2241`		`-WARNING: hash indexes are not WAL-logged andthus are not crash-safe and cannot be used on standby servers`
	`2241`	`+WARNING: hash indexes are not WAL-logged andtheir use is discouraged`
`2242`	`2242`	`CREATE INDEX hash_name_index ON hash_name_heap USING hash (random name_ops);`
`2243`		`-WARNING: hash indexes are not WAL-logged andthus are not crash-safe and cannot be used on standby servers`
	`2243`	`+WARNING: hash indexes are not WAL-logged andtheir use is discouraged`
`2244`	`2244`	`CREATE INDEX hash_txt_index ON hash_txt_heap USING hash (random text_ops);`
`2245`		`-WARNING: hash indexes are not WAL-logged andthus are not crash-safe and cannot be used on standby servers`
	`2245`	`+WARNING: hash indexes are not WAL-logged andtheir use is discouraged`
`2246`	`2246`	`CREATE INDEX hash_f8_index ON hash_f8_heap USING hash (random float8_ops);`
`2247`		`-WARNING: hash indexes are not WAL-logged andthus are not crash-safe and cannot be used on standby servers`
	`2247`	`+WARNING: hash indexes are not WAL-logged andtheir use is discouraged`
`2248`	`2248`	`-- CREATE INDEX hash_ovfl_index ON hash_ovfl_heap USING hash (x int4_ops);`
`2249`	`2249`	`--`
`2250`	`2250`	`-- Test functional index`

`‎src/test/regress/expected/enum.out`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -383,7 +383,7 @@ DROP INDEX enumtest_btree;`
`383`	`383`	`-- Hash index / opclass with the = operator`
`384`	`384`	`--`
`385`	`385`	`CREATE INDEX enumtest_hash ON enumtest USING hash (col);`
`386`		`-WARNING: hash indexes are not WAL-logged andthus are not crash-safe and cannot be used on standby servers`
	`386`	`+WARNING: hash indexes are not WAL-logged andtheir use is discouraged`
`387`	`387`	`SELECT * FROM enumtest WHERE col = 'orange';`
`388`	`388`	`col`
`389`	`389`	`--------`

`‎src/test/regress/expected/macaddr.out`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ SELECT * FROM macaddr_data;`
`39`	`39`
`40`	`40`	`CREATE INDEX macaddr_data_btree ON macaddr_data USING btree (b);`
`41`	`41`	`CREATE INDEX macaddr_data_hash ON macaddr_data USING hash (b);`
`42`		`-WARNING: hash indexes are not WAL-logged andthus are not crash-safe and cannot be used on standby servers`
	`42`	`+WARNING: hash indexes are not WAL-logged andtheir use is discouraged`
`43`	`43`	`SELECT a, b, trunc(b) FROM macaddr_data ORDER BY 2, 1;`
`44`	`44`	`a \| b \| trunc`
`45`	`45`	`----+-------------------+-------------------`

`‎src/test/regress/expected/replica_identity.out`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ CREATE INDEX test_replica_identity_keyab ON test_replica_identity (keya, keyb);`
`11`	`11`	`CREATE UNIQUE INDEX test_replica_identity_keyab_key ON test_replica_identity (keya, keyb);`
`12`	`12`	`CREATE UNIQUE INDEX test_replica_identity_nonkey ON test_replica_identity (keya, nonkey);`
`13`	`13`	`CREATE INDEX test_replica_identity_hash ON test_replica_identity USING hash (nonkey);`
`14`		`-WARNING: hash indexes are not WAL-logged andthus are not crash-safe and cannot be used on standby servers`
	`14`	`+WARNING: hash indexes are not WAL-logged andtheir use is discouraged`
`15`	`15`	`CREATE UNIQUE INDEX test_replica_identity_expr ON test_replica_identity (keya, keyb, (3));`
`16`	`16`	`CREATE UNIQUE INDEX test_replica_identity_partial ON test_replica_identity (keya, keyb) WHERE keyb != '3';`
`17`	`17`	`-- default is 'd'/DEFAULT for user created tables`

`‎src/test/regress/expected/uuid.out`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ SELECT COUNT(*) FROM guid1 WHERE guid_field >= '22222222-2222-2222-2222-22222222`
`114`	`114`	`-- btree and hash index creation test`
`115`	`115`	`CREATE INDEX guid1_btree ON guid1 USING BTREE (guid_field);`
`116`	`116`	`CREATE INDEX guid1_hash ON guid1 USING HASH (guid_field);`
`117`		`-WARNING: hash indexes are not WAL-logged andthus are not crash-safe and cannot be used on standby servers`
	`117`	`+WARNING: hash indexes are not WAL-logged andtheir use is discouraged`
`118`	`118`	`-- unique index test`
`119`	`119`	`CREATE UNIQUE INDEX guid1_unique_BTREE ON guid1 USING BTREE (guid_field);`
`120`	`120`	`-- should fail`

0 commit comments

Comments

(0)

[8]ページ先頭

©2009-2025 Movatter.jp