NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitb822ae1

committed

Use lfirst_int in cmp_list_len_contents_asc

The function added inbe45be9 is comparing integer lists (IntList) bylength and contents, but there were two bugs. Firstly, it used intVal()to extract the value, but that's for Value nodes, not for extracting intvalues from IntList. Secondly, it called it directly on the ListCell,without doing lfirst(). So just do lfirst_int() instead.Interestingly enough, this did not cause any crashes on the buildfarm,but valgrind rightfully complained about it.Discussion:https://postgr.es/m/bf3805a8-d7d1-ae61-fece-761b7ff41ecc@postgresfriends.org

1 parentd00fbdc commitb822ae1Copy full SHA for b822ae1

File tree

1 file changed

-2

lines changed

src/backend/parser
- parse_agg.c

1 file changed

-2

lines changed

`‎src/backend/parser/parse_agg.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1750,8 +1750,8 @@ cmp_list_len_contents_asc(const ListCell a, const ListCell b)`
`1750`	`1750`
`1751`	`1751`	`forboth(lca,la,lcb,lb)`
`1752`	`1752`	`{`
`1753`		`-intva=intVal(lca);`
`1754`		`-intvb=intVal(lcb);`
	`1753`	`+intva=lfirst_int(lca);`
	`1754`	`+intvb=lfirst_int(lcb);`
`1755`	`1755`	`if (va>vb)`
`1756`	`1756`	`return1;`
`1757`	`1757`	`if (va<vb)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb822ae1

File tree

1 file changed

1 file changed

`‎src/backend/parser/parse_agg.c`

0 commit comments