forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commitb818088
committed
In new pg_dump TAP tests, remove trailing "$" from regexps using /m.
It emerges that some Perl versions before 5.8.9 have a bug with regexpsthat use the /m flag and contain "$". This is the reason why jacanais still failing on HEAD, and I was able to duplicate the failure onprairiedog's host. There's no real need for "$" in these patterns,since they are already matching through the statement-terminatingsemicolons (or matching an explicit \n in some cases). So justremove it.Note: the reason jacana hasn't actually reported any failures in thelast little while is that the way the pg_dump TAP tests are set up, anyfailure of this sort results in echoing the entire pg_dump dump outputto stderr. Since there were about a hundred such failures, that resultedin a 30MB log file which choked the buildfarm upload script. There isroom for improvement here :-(.Per off-list discussion with Andrew and Stephen.1 parent691d99d commitb818088
1 file changed
+90
-90
lines changed0 commit comments
Comments
(0)