Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commitb7e84c6

Browse files
committed
Remove SQL regression tests for GUCs related to NO_SHOW_ALL
No GUCs that use NO_SHOW_ALL are reported in pg_show_all_settings(),hence trying to check combinations of flags related to it is pointless.These queries have been introduced byd10e41d, so backpatch down to 15to keep all the branches consistent. Equivalent checks based onNO_SHOW_ALL could be added in check_GUC_init() when a GUC is initiallyloaded, but this can be done only on HEAD.Author: Nitin JadhavDiscussion:https://postgr.es/m/CAMm1aWaYe0muu3ABo7iSAgK+OWDS9yNe8GGRYnCyeEpScYKa+g@mail.gmail.comBackpatch-through: 15
1 parent9ed50ab commitb7e84c6

File tree

2 files changed

+0
-41
lines changed

2 files changed

+0
-41
lines changed

‎src/test/regress/expected/guc.out

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -841,7 +841,6 @@ CREATE TABLE tab_settings_flags AS SELECT name, category,
841841
'EXPLAIN' = ANY(flags) AS explain,
842842
'NO_RESET' = ANY(flags) AS no_reset,
843843
'NO_RESET_ALL' = ANY(flags) AS no_reset_all,
844-
'NO_SHOW_ALL' = ANY(flags) AS no_show_all,
845844
'NOT_IN_SAMPLE' = ANY(flags) AS not_in_sample,
846845
'RUNTIME_COMPUTED' = ANY(flags) AS runtime_computed
847846
FROM pg_show_all_settings() AS psas,
@@ -880,33 +879,6 @@ SELECT name FROM tab_settings_flags
880879
------
881880
(0 rows)
882881

883-
-- NO_SHOW_ALL implies NO_RESET_ALL, and vice-versa.
884-
SELECT name FROM tab_settings_flags
885-
WHERE no_show_all AND NOT no_reset_all
886-
ORDER BY 1;
887-
name
888-
------
889-
(0 rows)
890-
891-
-- Exceptions are transaction_*.
892-
SELECT name FROM tab_settings_flags
893-
WHERE NOT no_show_all AND no_reset_all
894-
ORDER BY 1;
895-
name
896-
------------------------
897-
transaction_deferrable
898-
transaction_isolation
899-
transaction_read_only
900-
(3 rows)
901-
902-
-- NO_SHOW_ALL implies NOT_IN_SAMPLE.
903-
SELECT name FROM tab_settings_flags
904-
WHERE no_show_all AND NOT not_in_sample
905-
ORDER BY 1;
906-
name
907-
------
908-
(0 rows)
909-
910882
-- NO_RESET implies NO_RESET_ALL.
911883
SELECT name FROM tab_settings_flags
912884
WHERE no_reset AND NOT no_reset_all

‎src/test/regress/sql/guc.sql

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,6 @@ CREATE TABLE tab_settings_flags AS SELECT name, category,
326326
'EXPLAIN'= ANY(flags)AS explain,
327327
'NO_RESET'= ANY(flags)AS no_reset,
328328
'NO_RESET_ALL'= ANY(flags)AS no_reset_all,
329-
'NO_SHOW_ALL'= ANY(flags)AS no_show_all,
330329
'NOT_IN_SAMPLE'= ANY(flags)AS not_in_sample,
331330
'RUNTIME_COMPUTED'= ANY(flags)AS runtime_computed
332331
FROM pg_show_all_settings()AS psas,
@@ -349,18 +348,6 @@ SELECT name FROM tab_settings_flags
349348
SELECT nameFROM tab_settings_flags
350349
WHERE category='Preset Options'AND NOT not_in_sample
351350
ORDER BY1;
352-
-- NO_SHOW_ALL implies NO_RESET_ALL, and vice-versa.
353-
SELECT nameFROM tab_settings_flags
354-
WHERE no_show_allAND NOT no_reset_all
355-
ORDER BY1;
356-
-- Exceptions are transaction_*.
357-
SELECT nameFROM tab_settings_flags
358-
WHERE NOT no_show_allAND no_reset_all
359-
ORDER BY1;
360-
-- NO_SHOW_ALL implies NOT_IN_SAMPLE.
361-
SELECT nameFROM tab_settings_flags
362-
WHERE no_show_allAND NOT not_in_sample
363-
ORDER BY1;
364351
-- NO_RESET implies NO_RESET_ALL.
365352
SELECT nameFROM tab_settings_flags
366353
WHERE no_resetAND NOT no_reset_all

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp