NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitb7cc21c

committed

pg_dump: fix dependencies on FKs to partitioned tables

Parallel-restoring a foreign key that references a partitioned tablewith several levels of partitions can fail:pg_restore: while PROCESSING TOC:pg_restore: from TOC entry 6684; 2606 29166 FK CONSTRAINT fk fk_a_fkey postgrespg_restore: error: could not execute query: ERROR: there is no unique constraint matching given keys for referenced table "pk"Command was: ALTER TABLE fkpart3.fk ADD CONSTRAINT fk_a_fkey FOREIGN KEY (a) REFERENCES fkpart3.pk(a);This happens in parallel restore mode because some index partitionsaren't yet attached to the topmost partitioned index that the FK uses,and so the index is still invalid. The current code marks the FK asdependent on the first level of index-attach dump objects; the bug isfixed by recursively marking the FK on their children.Backpatch to 12, where FKs to partitioned tables were introduced.Reported-by: Tom Lane <tgl@sss.pgh.pa.us>Author: Álvaro Herrera <alvherre@alvh.no-ip.org>Discussion:https://postgr.es/m/3170626.1594842723@sss.pgh.pa.usBackpatch: 12-master

1 parent1c6066f commitb7cc21cCopy full SHA for b7cc21c

File tree

1 file changed

+34

-7

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

+34

-7

lines changed

`‎src/bin/pg_dump/pg_dump.c`

Lines changed: 34 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -235,6 +235,7 @@ static DumpableObject *createBoundaryObjects(void);`
`235`	`235`	`static void addBoundaryDependencies(DumpableObject **dobjs, int numObjs,`
`236`	`236`	`DumpableObject *boundaryObjs);`
`237`	`237`
	`238`	`+static void addConstrChildIdxDeps(DumpableObject dobj, IndxInfo refidx);`
`238`	`239`	`static void getDomainConstraints(Archive fout, TypeInfo tyinfo);`
`239`	`240`	`static void getTableData(DumpOptions dopt, TableInfo tblinfo, int numTables, char relkind);`
`240`	`241`	`static void makeTableDataInfo(DumpOptions dopt, TableInfo tbinfo);`
`@@ -7514,25 +7515,20 @@ getConstraints(Archive *fout, TableInfo tblinfo[], int numTables)`
`7514`	`7515`	`reftable = findTableByOid(constrinfo[j].confrelid);`
`7515`	`7516`	`if (reftable && reftable->relkind == RELKIND_PARTITIONED_TABLE)`
`7516`	`7517`	`{`
`7517`		`-IndxInfo *refidx;`
`7518`	`7518`	`OidindexOid = atooid(PQgetvalue(res, j, i_conindid));`
`7519`	`7519`
`7520`	`7520`	`if (indexOid != InvalidOid)`
`7521`	`7521`	`{`
`7522`	`7522`	`for (int k = 0; k < reftable->numIndexes; k++)`
`7523`	`7523`	`{`
`7524`		`-SimplePtrListCell *cell;`
	`7524`	`+IndxInfo *refidx;`
`7525`	`7525`
`7526`	`7526`	`/* not our index? */`
`7527`	`7527`	`if (reftable->indexes[k].dobj.catId.oid != indexOid)`
`7528`	`7528`	`continue;`
`7529`	`7529`
`7530`	`7530`	`refidx = &reftable->indexes[k];`
`7531`		`-for (cell = refidx->partattaches.head; cell;`
`7532`		`- cell = cell->next)`
`7533`		`-addObjectDependency(&constrinfo[j].dobj,`
`7534`		`-((DumpableObject *)`
`7535`		`- cell->ptr)->dumpId);`
	`7531`	`+addConstrChildIdxDeps(&constrinfo[j].dobj, refidx);`
`7536`	`7532`	`break;`
`7537`	`7533`	`}`
`7538`	`7534`	`}`
`@@ -7545,6 +7541,37 @@ getConstraints(Archive *fout, TableInfo tblinfo[], int numTables)`
`7545`	`7541`	`destroyPQExpBuffer(query);`
`7546`	`7542`	`}`
`7547`	`7543`
	`7544`	`+/*`
	`7545`	`+ * addConstrChildIdxDeps`
	`7546`	`+ *`
	`7547`	`+ * Recursive subroutine for getConstraints`
	`7548`	`+ *`
	`7549`	`+ * Given an object representing a foreign key constraint and an index on the`
	`7550`	`+ * partitioned table it references, mark the constraint object as dependent`
	`7551`	`+ * on each partition, recursing to children until all leaves are found.`
	`7552`	`+ * This ensures that the FK is not restored until the index is fully marked`
	`7553`	`+ * valid.`
	`7554`	`+ */`
	`7555`	`+static void`
	`7556`	`+addConstrChildIdxDeps(DumpableObject dobj, IndxInfo refidx)`
	`7557`	`+{`
	`7558`	`+SimplePtrListCell *cell;`
	`7559`	`+`
	`7560`	`+Assert(dobj->objType == DO_FK_CONSTRAINT);`
	`7561`	`+`
	`7562`	`+for (cell = refidx->partattaches.head; cell; cell = cell->next)`
	`7563`	`+{`
	`7564`	`+DumpableObject childobj = (DumpableObject ) cell->ptr;`
	`7565`	`+IndexAttachInfo *attach;`
	`7566`	`+`
	`7567`	`+addObjectDependency(dobj, childobj->dumpId);`
	`7568`	`+`
	`7569`	`+attach = (IndexAttachInfo *) childobj;`
	`7570`	`+if (attach->partitionIdx->partattaches.head != NULL)`
	`7571`	`+addConstrChildIdxDeps(dobj, attach->partitionIdx);`
	`7572`	`+}`
	`7573`	`+}`
	`7574`	`+`
`7548`	`7575`	`/*`
`7549`	`7576`	`* getDomainConstraints`
`7550`	`7577`	`*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb7cc21c

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c`

0 commit comments