NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitb783a38

committed

Fix failure of --jobs with vacuumdb on Windows

FD_SETSIZE needs to be declared before winsock2.h, or it is possible torun into buffer overflow issues when using --jobs. This is similar topgbench's solution done ina23c641.This has been introduced by71d84ef, and older versions have been usingthe default value of FD_SETSIZE, defined at 64.Per buildfarm member jacana, but this impacts all Windows animalsrunning the TAP tests. I have reproduced the failure locally to checkthe patch.Author: Michael PaquierReviewed-by: Andrew DunstanDiscussion:https://postgr.es/m/20190826054000.GE7005@paquier.xyzBackpatch-through: 9.5

1 parent6bdd9fb commitb783a38Copy full SHA for b783a38

File tree

1 file changed

-0

lines changed

src/bin/scripts
- vacuumdb.c

1 file changed

-0

lines changed

`‎src/bin/scripts/vacuumdb.c‎`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,10 @@`
`10`	`10`	`*-------------------------------------------------------------------------`
`11`	`11`	`*/`
`12`	`12`
	`13`	`+#ifdefWIN32`
	`14`	`+#defineFD_SETSIZE 1024/* must set before winsock2.h is included */`
	`15`	`+#endif`
	`16`	`+`
`13`	`17`	`#include"postgres_fe.h"`
`14`	`18`
`15`	`19`	`#ifdefHAVE_SYS_SELECT_H`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb783a38

File tree

1 file changed

1 file changed

`‎src/bin/scripts/vacuumdb.c‎`

0 commit comments