NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitb733331

committed

ProcedureCreate neglected to record dependencies on default expressions.

Thus, an object referenced in a default expression could be dropped whilethe function remained present. This was unaccountably missed in theoriginal patch to add default parameters for functions. Reported byPavel Stehule.

1 parent96a263f commitb733331Copy full SHA for b733331

File tree

1 file changed

-0

lines changed

src/backend/catalog
- pg_proc.c

1 file changed

-0

lines changed

`‎src/backend/catalog/pg_proc.c`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -598,6 +598,11 @@ ProcedureCreate(const char *procedureName,`
`598`	`598`	`recordDependencyOn(&myself,&referenced,DEPENDENCY_NORMAL);`
`599`	`599`	`}`
`600`	`600`
	`601`	`+/* dependency on parameter default expressions */`
	`602`	`+if (parameterDefaults)`
	`603`	`+recordDependencyOnExpr(&myself, (Node*)parameterDefaults,`
	`604`	`+NIL,DEPENDENCY_NORMAL);`
	`605`	`+`
`601`	`606`	`/* dependency on owner */`
`602`	`607`	`if (!is_update)`
`603`	`608`	`recordDependencyOnOwner(ProcedureRelationId,retval,proowner);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb733331

File tree

1 file changed

1 file changed

`‎src/backend/catalog/pg_proc.c`

0 commit comments