forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commitb6e3a3a
Better handle pseudotypes as partition keys
We fail to handle polymorphic types properly when they are used aspartition keys: we were unnecessarily adding a RelabelType node on top,which confuses code examining the nodes. In particular, this makespredtest.c-based partition pruning not to work, and ruleutils.c to emitexpressions that are uglier than needed. Fix it by not adding RelabelTypewhen not needed.In master/11 the new pruning code is separate so it doesn't suffer fromthis problem, since we already fixed it (in essentially the same way) ine5dcbb8, which also added a few tests; back-patch those tests topg10 also. But since UPDATE/DELETE still uses predtest.c in pg11, thischange improves partitioning for those cases too. Add tests for this.The ruleutils.c behavior change is relevant in pg11/master too.Co-authored-by: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>Co-authored-by: Álvaro Herrera <alvherre@alvh.no-ip.org>Reviewed-by: Álvaro Herrera <alvherre@alvh.no-ip.org>Reviewed-by: Robert Haas <robertmhaas@gmail.com>Discussion:https://postgr.es/m/54745d13-7ed4-54ac-97d8-ea1eec95ae25@lab.ntt.co.jp1 parentbcbd940 commitb6e3a3a
File tree
4 files changed
+41
-31
lines changed- src
- backend/partitioning
- test/regress
- expected
- sql
4 files changed
+41
-31
lines changedLines changed: 20 additions & 30 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1144 | 1144 |
| |
1145 | 1145 |
| |
1146 | 1146 |
| |
1147 |
| - | |
1148 |
| - | |
| 1147 | + | |
| 1148 | + | |
| 1149 | + | |
| 1150 | + | |
| 1151 | + | |
| 1152 | + | |
1149 | 1153 |
| |
1150 | 1154 |
| |
1151 | 1155 |
| |
| |||
1154 | 1158 |
| |
1155 | 1159 |
| |
1156 | 1160 |
| |
1157 |
| - | |
1158 |
| - | |
1159 |
| - | |
| 1161 | + | |
| 1162 | + | |
1160 | 1163 |
| |
1161 | 1164 |
| |
1162 |
| - | |
1163 |
| - | |
| 1165 | + | |
| 1166 | + | |
1164 | 1167 |
| |
| 1168 | + | |
| 1169 | + | |
| 1170 | + | |
| 1171 | + | |
1165 | 1172 |
| |
1166 | 1173 |
| |
1167 |
| - | |
1168 |
| - | |
1169 |
| - | |
1170 |
| - | |
1171 |
| - | |
1172 |
| - | |
1173 |
| - | |
1174 |
| - | |
1175 |
| - | |
| 1174 | + | |
| 1175 | + | |
| 1176 | + | |
1176 | 1177 |
| |
1177 |
| - | |
1178 |
| - | |
1179 |
| - | |
1180 |
| - | |
1181 |
| - | |
1182 |
| - | |
1183 |
| - | |
1184 |
| - | |
1185 |
| - | |
1186 |
| - | |
1187 |
| - | |
1188 |
| - | |
1189 |
| - | |
1190 |
| - | |
| 1178 | + | |
| 1179 | + | |
| 1180 | + | |
1191 | 1181 |
| |
1192 | 1182 |
| |
1193 | 1183 |
| |
|
Lines changed: 1 addition & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
882 | 882 |
| |
883 | 883 |
| |
884 | 884 |
| |
885 |
| - | |
| 885 | + | |
886 | 886 |
| |
887 | 887 |
| |
888 | 888 |
| |
|
Lines changed: 18 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
2817 | 2817 |
| |
2818 | 2818 |
| |
2819 | 2819 |
| |
| 2820 | + | |
| 2821 | + | |
| 2822 | + | |
| 2823 | + | |
| 2824 | + | |
| 2825 | + | |
| 2826 | + | |
| 2827 | + | |
| 2828 | + | |
| 2829 | + | |
| 2830 | + | |
| 2831 | + | |
| 2832 | + | |
| 2833 | + | |
| 2834 | + | |
| 2835 | + | |
| 2836 | + | |
| 2837 | + | |
2820 | 2838 |
| |
2821 | 2839 |
| |
2822 | 2840 |
| |
|
Lines changed: 2 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
721 | 721 |
| |
722 | 722 |
| |
723 | 723 |
| |
| 724 | + | |
| 725 | + | |
724 | 726 |
| |
725 | 727 |
| |
726 | 728 |
| |
|
0 commit comments
Comments
(0)