Commitb6c15e7

committed

Correct obsolete UNION hash aggs comment.

Oversight in commit1f39bce, which added disk-based hash aggregation.Backpatch: 13-, where disk-based hash aggregation was introduced.

1 parente362f46 commitb6c15e7Copy full SHA for b6c15e7

File tree

-5

lines changed

-5

lines changed

Lines changed: 4 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -944,11 +944,10 @@ make_union_unique(SetOperationStmt op, Path path, List *tlist,`
`944`	`944`
`945`	`945`	`/*`
`946`	`946`	`* XXX for the moment, take the number of distinct groups as equal to the`
`947`		`- * total input size, ie, the worst case. This is too conservative, but we`
`948`		`- * don't want to risk having the hashtable overrun memory; also, it's not`
`949`		`- * clear how to get a decent estimate of the true size. One should note`
`950`		`- * as well the propensity of novices to write UNION rather than UNION ALL`
`951`		`- * even when they don't expect any duplicates...`
	`947`	`+ * total input size, ie, the worst case. This is too conservative, but`
	`948`	`+ * it's not clear how to get a decent estimate of the true size. One`
	`949`	`+ * should note as well the propensity of novices to write UNION rather`
	`950`	`+ * than UNION ALL even when they don't expect any duplicates...`
`952`	`951`	`*/`
`953`	`952`	`dNumGroups=path->rows;`
`954`	`953`

Comments

(0)