forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commitb6aa17e
committed
De-support floating-point timestamps.
Per discussion, the time has come to do this. The handwriting has beenon the wall at least since 9.0 that this would happen someday, wheneverit got to be too much of a burden to support the float-timestamp option.The triggering factor now is the discovery that there are multiple bugsin the code that attempts to implement use of integer timestamps in thereplication protocol even when the server is built for float timestamps.The internal float timestamps leak into the protocol fields in places.While we could fix the identified bugs, there's a very high risk ofintroducing more. Trying to build a wall that would positively preventmixing integer and float timestamps is more complexity than we want toundertake to maintain a long-deprecated option. The fact that thesebugs weren't found through testing also indicates a lack of interestin float timestamps.This commit disables configure's --disable-integer-datetimes switch(it'll still accept --enable-integer-datetimes, though), removes directreferences to USE_INTEGER_DATETIMES, and removes discussion of floattimestamps from the user documentation. A considerable amount of code isrendered dead by this, but removing that will occur as separate mop-up.Discussion:https://postgr.es/m/26788.1487455319@sss.pgh.pa.us1 parentc3368f9 commitb6aa17e
File tree
15 files changed
+36
-124
lines changed- doc/src/sgml
- src
- include
- interfaces/ecpg
- include
- test
- expected
- pgtypeslib
- tools/msvc
15 files changed
+36
-124
lines changedLines changed: 6 additions & 12 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1473 | 1473 |
| |
1474 | 1474 |
| |
1475 | 1475 |
| |
1476 |
| - | |
| 1476 | + | |
1477 | 1477 |
| |
1478 | 1478 |
| |
1479 | 1479 |
| |
| |||
2984 | 2984 |
| |
2985 | 2985 |
| |
2986 | 2986 |
| |
2987 |
| - | |
| 2987 | + | |
| 2988 | + | |
| 2989 | + | |
2988 | 2990 |
| |
2989 |
| - | |
2990 |
| - | |
2991 | 2991 |
| |
2992 | 2992 |
| |
2993 | 2993 |
| |
2994 | 2994 |
| |
2995 | 2995 |
| |
2996 | 2996 |
| |
2997 | 2997 |
| |
2998 |
| - | |
2999 |
| - | |
3000 |
| - | |
| 2998 | + | |
3001 | 2999 |
| |
3002 | 3000 |
| |
3003 |
| - | |
| 3001 | + | |
3004 | 3002 |
| |
3005 | 3003 |
| |
3006 | 3004 |
| |
| |||
3010 | 3008 |
| |
3011 | 3009 |
| |
3012 | 3010 |
| |
3013 |
| - | |
3014 |
| - | |
3015 | 3011 |
| |
3016 | 3012 |
| |
3017 | 3013 |
| |
3018 |
| - | |
3019 |
| - | |
3020 | 3014 |
| |
3021 | 3015 |
| |
3022 | 3016 |
| |
|
Lines changed: 6 additions & 6 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
122 | 122 |
| |
123 | 123 |
| |
124 | 124 |
| |
125 |
| - | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
126 | 128 |
| |
127 |
| - | |
128 |
| - | |
129 |
| - | |
130 |
| - | |
131 |
| - | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
132 | 132 |
| |
133 | 133 |
| |
134 | 134 |
| |
|
Lines changed: 3 additions & 5 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
7695 | 7695 |
| |
7696 | 7696 |
| |
7697 | 7697 |
| |
7698 |
| - | |
7699 |
| - | |
7700 |
| - | |
7701 |
| - | |
7702 |
| - | |
| 7698 | + | |
| 7699 | + | |
| 7700 | + | |
7703 | 7701 |
| |
7704 | 7702 |
| |
7705 | 7703 |
| |
|
Lines changed: 11 additions & 44 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1580 | 1580 |
| |
1581 | 1581 |
| |
1582 | 1582 |
| |
1583 |
| - | |
| 1583 | + | |
1584 | 1584 |
| |
1585 | 1585 |
| |
1586 | 1586 |
| |
1587 | 1587 |
| |
1588 | 1588 |
| |
1589 | 1589 |
| |
1590 | 1590 |
| |
1591 |
| - | |
| 1591 | + | |
1592 | 1592 |
| |
1593 | 1593 |
| |
1594 | 1594 |
| |
| |||
1604 | 1604 |
| |
1605 | 1605 |
| |
1606 | 1606 |
| |
1607 |
| - | |
| 1607 | + | |
1608 | 1608 |
| |
1609 | 1609 |
| |
1610 | 1610 |
| |
1611 | 1611 |
| |
1612 |
| - | |
| 1612 | + | |
1613 | 1613 |
| |
1614 | 1614 |
| |
1615 |
| - | |
| 1615 | + | |
1616 | 1616 |
| |
1617 | 1617 |
| |
1618 | 1618 |
| |
1619 | 1619 |
| |
1620 | 1620 |
| |
1621 | 1621 |
| |
1622 | 1622 |
| |
1623 |
| - | |
| 1623 | + | |
1624 | 1624 |
| |
1625 | 1625 |
| |
1626 | 1626 |
| |
| |||
1643 | 1643 |
| |
1644 | 1644 |
| |
1645 | 1645 |
| |
1646 |
| - | |
1647 |
| - | |
1648 |
| - | |
1649 |
| - | |
1650 |
| - | |
1651 |
| - | |
1652 |
| - | |
1653 |
| - | |
1654 |
| - | |
1655 |
| - | |
1656 |
| - | |
1657 |
| - | |
1658 |
| - | |
1659 |
| - | |
1660 |
| - | |
1661 |
| - | |
1662 |
| - | |
1663 |
| - | |
1664 |
| - | |
1665 |
| - | |
1666 |
| - | |
1667 |
| - | |
1668 |
| - | |
1669 |
| - | |
1670 |
| - | |
1671 |
| - | |
1672 |
| - | |
1673 |
| - | |
1674 |
| - | |
1675 |
| - | |
1676 |
| - | |
1677 |
| - | |
1678 |
| - | |
1679 |
| - | |
1680 |
| - | |
| 1646 | + | |
1681 | 1647 |
| |
1682 | 1648 |
| |
1683 | 1649 |
| |
| |||
1760 | 1726 |
| |
1761 | 1727 |
| |
1762 | 1728 |
| |
1763 |
| - | |
1764 |
| - | |
1765 |
| - | |
| 1729 | + | |
| 1730 | + | |
| 1731 | + | |
| 1732 | + | |
1766 | 1733 |
| |
1767 | 1734 |
| |
1768 | 1735 |
| |
|
Lines changed: 0 additions & 22 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
955 | 955 |
| |
956 | 956 |
| |
957 | 957 |
| |
958 |
| - | |
959 |
| - | |
960 |
| - | |
961 |
| - | |
962 |
| - | |
963 |
| - | |
964 |
| - | |
965 |
| - | |
966 |
| - | |
967 |
| - | |
968 |
| - | |
969 |
| - | |
970 |
| - | |
971 |
| - | |
972 |
| - | |
973 |
| - | |
974 |
| - | |
975 |
| - | |
976 |
| - | |
977 |
| - | |
978 |
| - | |
979 |
| - | |
980 | 958 |
| |
981 | 959 |
| |
982 | 960 |
| |
|
Lines changed: 4 additions & 3 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
340 | 340 |
| |
341 | 341 |
| |
342 | 342 |
| |
343 |
| - | |
344 |
| - | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
345 | 347 |
| |
346 |
| - | |
347 | 348 |
| |
348 | 349 |
| |
349 | 350 |
| |
|
Lines changed: 0 additions & 4 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
831 | 831 |
| |
832 | 832 |
| |
833 | 833 |
| |
834 |
| - | |
835 |
| - | |
836 |
| - | |
837 |
| - | |
838 | 834 |
| |
839 | 835 |
| |
840 | 836 |
| |
|
Lines changed: 0 additions & 4 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
625 | 625 |
| |
626 | 626 |
| |
627 | 627 |
| |
628 |
| - | |
629 |
| - | |
630 |
| - | |
631 |
| - | |
632 | 628 |
| |
633 | 629 |
| |
634 | 630 |
| |
|
Lines changed: 0 additions & 4 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
10 | 10 |
| |
11 | 11 |
| |
12 | 12 |
| |
13 |
| - | |
14 |
| - | |
15 |
| - | |
16 |
| - | |
17 | 13 |
| |
18 | 14 |
| |
19 | 15 |
|
Lines changed: 0 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
20 | 20 |
| |
21 | 21 |
| |
22 | 22 |
| |
23 |
| - | |
24 | 23 |
| |
25 |
| - | |
26 | 24 |
| |
27 | 25 |
| |
28 | 26 |
| |
|
Lines changed: 2 additions & 4 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
145 | 145 |
| |
146 | 146 |
| |
147 | 147 |
| |
148 |
| - | |
149 |
| - | |
150 |
| - | |
151 |
| - | |
| 148 | + | |
| 149 | + | |
152 | 150 |
| |
153 | 151 |
| |
154 | 152 |
| |
|
Lines changed: 2 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
103 | 103 |
| |
104 | 104 |
| |
105 | 105 |
| |
| 106 | + | |
| 107 | + | |
106 | 108 |
| |
107 | 109 |
| |
108 | 110 |
| |
|
Lines changed: 2 additions & 4 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
110 | 110 |
| |
111 | 111 |
| |
112 | 112 |
| |
113 |
| - | |
114 |
| - | |
115 |
| - | |
116 |
| - | |
| 113 | + | |
| 114 | + | |
117 | 115 |
| |
118 | 116 |
| |
119 | 117 |
| |
|
Lines changed: 0 additions & 9 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
28 | 28 |
| |
29 | 29 |
| |
30 | 30 |
| |
31 |
| - | |
32 |
| - | |
33 |
| - | |
34 | 31 |
| |
35 | 32 |
| |
36 | 33 |
| |
| |||
169 | 166 |
| |
170 | 167 |
| |
171 | 168 |
| |
172 |
| - | |
173 |
| - | |
174 | 169 |
| |
175 | 170 |
| |
176 | 171 |
| |
| |||
427 | 422 |
| |
428 | 423 |
| |
429 | 424 |
| |
430 |
| - | |
431 |
| - | |
432 | 425 |
| |
433 | 426 |
| |
434 | 427 |
| |
| |||
661 | 654 |
| |
662 | 655 |
| |
663 | 656 |
| |
664 |
| - | |
665 |
| - | |
666 | 657 |
| |
667 | 658 |
| |
668 | 659 |
| |
|
Lines changed: 0 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
4 | 4 |
| |
5 | 5 |
| |
6 | 6 |
| |
7 |
| - | |
8 | 7 |
| |
9 | 8 |
| |
10 | 9 |
| |
|
0 commit comments
Comments
(0)