NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitb6558e4

committed

nbtree: Remove useless 'strat' local variable.

Remove a local variable that was used to avoid overwriting strat_totalwith the = operator strategy when a >= operator strategy key was alreadyincluded in the initial positioning/insertion scan keys by _bt_first(for backwards scans it would have to be a <= key that was included)._bt_first's strat_total local variable now simply tracks the operatorstrategy of the final scan key that was included in the scan's insertionscan key (barring the case where the !used_all_subkeys row compare pathadjusts strat_total in its own way)._bt_first already treated >= keys (or <= keys) as = keys for initialpositioning purposes. There is no good reason to remember that that waswhat happened; no later _bt_first step cares about the distinction.Note, in particular, that the insertion scan key's 'nextkey' and'backward' fields will be initialized the same way regardless.Author: Peter Geoghegan <pg@bowt.ie>Reviewed-By: Tomas Vondra <tomas@vondra.me>Discussion:https://postgr.es/m/CAH2-Wz=PKR6rB7qbx+Vnd7eqeB5VTcrW=iJvAsTsKbdG+kW_UA@mail.gmail.com

1 parent3c0fd64 commitb6558e4Copy full SHA for b6558e4

File tree

1 file changed

-13

lines changed

src/backend/access/nbtree
- nbtsearch.c

1 file changed

-13

lines changed

`‎src/backend/access/nbtree/nbtsearch.c`

Lines changed: 5 additions & 13 deletions

Original file line number	Diff line number	Diff line change
`@@ -883,7 +883,6 @@ _bt_first(IndexScanDesc scan, ScanDirection dir)`
`883`	`883`	`BTScanOpaqueso= (BTScanOpaque)scan->opaque;`
`884`	`884`	`BTStackstack;`
`885`	`885`	`OffsetNumberoffnum;`
`886`		`-StrategyNumberstrat;`
`887`	`886`	`BTScanInsertDatainskey;`
`888`	`887`	`ScanKeystartKeys[INDEX_MAX_KEYS];`
`889`	`888`	`ScanKeyDatanotnullkeys[INDEX_MAX_KEYS];`
`@@ -1090,18 +1089,11 @@ _bt_first(IndexScanDesc scan, ScanDirection dir)`
`1090`	`1089`	`break;`
`1091`	`1090`	`startKeys[keysz++]=chosen;`
`1092`	`1091`
`1093`		`-/*`
`1094`		`- * Adjust strat_total, and quit if we have stored a > or <`
`1095`		`- * key.`
`1096`		`- */`
`1097`		`-strat=chosen->sk_strategy;`
`1098`		`-if (strat!=BTEqualStrategyNumber)`
`1099`		`-{`
`1100`		`-strat_total=strat;`
`1101`		`-if (strat==BTGreaterStrategyNumber\|\|`
`1102`		`-strat==BTLessStrategyNumber)`
`1103`		`-break;`
`1104`		`-}`
	`1092`	`+/* Quit if we have stored a > or < key */`
	`1093`	`+strat_total=chosen->sk_strategy;`
	`1094`	`+if (strat_total==BTGreaterStrategyNumber\|\|`
	`1095`	`+strat_total==BTLessStrategyNumber)`
	`1096`	`+break;`
`1105`	`1097`
`1106`	`1098`	`/*`
`1107`	`1099`	`* Done if that was the last attribute, or if next key is not`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb6558e4

File tree

1 file changed

1 file changed

`‎src/backend/access/nbtree/nbtsearch.c`

0 commit comments