NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitb4f79d2

committed

Mark PlanState as an abstract node type.

In the same vein as commit251154b, make it clear that we neverinstantiate PlanState.Also mark MemoryContextData as abstract. This has no effect right now,since memnodes.h isn't one of the files fed to gen_node_support.pl.But it seems like good documentation and future-proofing.

1 parent2be87f0 commitb4f79d2Copy full SHA for b4f79d2

File tree

3 files changed

-3

lines changed

src
- include/nodes
  - execnodes.h
  - memnodes.h
- test/modules/test_oat_hooks
  - test_oat_hooks.c

3 files changed

-3

lines changed

`‎src/include/nodes/execnodes.h`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -999,6 +999,8 @@ typedef TupleTableSlot (ExecProcNodeMtd) (struct PlanState *pstate);`
`999`	`999`	`*/`
`1000`	`1000`	`typedefstructPlanState`
`1001`	`1001`	`{`
	`1002`	`+pg_node_attr(abstract)`
	`1003`	`+`
`1002`	`1004`	`NodeTagtype;`
`1003`	`1005`
`1004`	`1006`	`Planplan;/ associated Plan node */`

`‎src/include/nodes/memnodes.h`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -77,6 +77,8 @@ typedef struct MemoryContextMethods`
`77`	`77`
`78`	`78`	`typedefstructMemoryContextData`
`79`	`79`	`{`
	`80`	`+pg_node_attr(abstract)/* there are no nodes of this type */`
	`81`	`+`
`80`	`82`	`NodeTagtype;/* identifies exact kind of context */`
`81`	`83`	`/* these two fields are placed here to minimize alignment wastage: */`
`82`	`84`	`boolisReset;/* T = no space alloced since last reset */`

`‎src/test/modules/test_oat_hooks/test_oat_hooks.c`

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -618,9 +618,6 @@ nodetag_to_string(NodeTag tag)`
`618`	`618`	`caseT_PlanInvalItem:`
`619`	`619`	`return"PlanInvalItem";`
`620`	`620`	`break;`
`621`		`-caseT_PlanState:`
`622`		`-return"PlanState";`
`623`		`-break;`
`624`	`621`	`caseT_ResultState:`
`625`	`622`	`return"ResultState";`
`626`	`623`	`break;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb4f79d2

File tree

3 files changed

3 files changed

`‎src/include/nodes/execnodes.h`

`‎src/include/nodes/memnodes.h`

`‎src/test/modules/test_oat_hooks/test_oat_hooks.c`

0 commit comments