Commitb4da9d0

committed

brin: Don't crash on auto-summarization

We were trying to free a pointer into a shared buffer, which neverworks; and we were failing to release the buffer lock appropriately.Fix those omissions.While at it, improve documentation for brinGetTupleForHeapBlock, theinadequacy of which evidently caused these bugs in the first place.Reported independently by Zhou Digoal (bug #14668) and Alexander Sosna.Discussion:https://postgr.es/m/8c31c11b-6adb-228d-22c2-4ace89fc9209@credativ.deDiscussion:https://postgr.es/m/20170524063323.29941.46339@wrigleys.postgresql.org

1 parente6785a5 commitb4da9d0Copy full SHA for b4da9d0

File tree

+10

-6

lines changed

+10

-6

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -190,7 +190,8 @@ brininsert(Relation idxRel, Datum values, bool nulls,`
`190`	`190`	`AutoVacuumRequestWork(AVW_BRINSummarizeRange,`
`191`	`191`	`RelationGetRelid(idxRel),`
`192`	`192`	`lastPageRange);`
`193`		`-brin_free_tuple(lastPageTuple);`
	`193`	`+else`
	`194`	`+LockBuffer(buf,BUFFER_LOCK_UNLOCK);`
`194`	`195`	`}`
`195`	`196`
`196`	`197`	`brtup=brinGetTupleForHeapBlock(revmap,heapBlk,&buf,&off,`

Lines changed: 8 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -179,13 +179,16 @@ brinSetHeapBlockItemptr(Buffer buf, BlockNumber pagesPerRange,`
`179`	`179`	`/*`
`180`	`180`	`* Fetch the BrinTuple for a given heap block.`
`181`	`181`	`*`
`182`		`- * The buffer containing the tuple is locked, and returned in *buf. As an`
`183`		`- * optimization, the caller can pass a pinned buffer *buf on entry, which will`
`184`		`- * avoid a pin-unpin cycle when the next tuple is on the same page as a`
`185`		`- * previous one.`
	`182`	`+ * The buffer containing the tuple is locked, and returned in *buf. The`
	`183`	`+ * returned tuple points to the shared buffer and must not be freed; if caller`
	`184`	`+ * wants to use it after releasing the buffer lock, it must create its own`
	`185`	`+ * palloc'ed copy. As an optimization, the caller can pass a pinned buffer`
	`186`	`+ * *buf on entry, which will avoid a pin-unpin cycle when the next tuple is on`
	`187`	`+ * the same page as a previous one.`
`186`	`188`	`*`
`187`	`189`	`* If no tuple is found for the given heap range, returns NULL. In that case,`
`188`		`- * *buf might still be updated, but it's not locked.`
	`190`	`+ * *buf might still be updated (and pin must be released by caller), but it's`
	`191`	`+ * not locked.`
`189`	`192`	`*`
`190`	`193`	`* The output tuple offset within the buffer is returned in *off, and its size`
`191`	`194`	`* is returned in *size.`

Comments

(0)