NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitb48af6d

committed

Fix initdb's handling of min_wal_size and max_wal_size.

In commit3e51b27, I misinterpreted the coding in setup_config()as setting min_wal_size and max_wal_size to compile-time-constantvalues. But it's not: there's a hidden dependency on --wal-segsize.Therefore leaving these variables commented out is the wrong thing.Per report from Andres Freund.Discussion:https://postgr.es/m/20230322200751.jvfvsuuhd3hgm6vv@awork3.anarazel.de

1 parent4fe2aa7 commitb48af6dCopy full SHA for b48af6d

File tree

1 file changed

-6

lines changed

src/bin/initdb
- initdb.c

1 file changed

-6

lines changed

`‎src/bin/initdb/initdb.c`

Lines changed: 7 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -1279,6 +1279,13 @@ setup_config(void)`
`1279`	`1279`	`conflines=replace_guc_value(conflines,"dynamic_shared_memory_type",`
`1280`	`1280`	`dynamic_shared_memory_type, false);`
`1281`	`1281`
	`1282`	`+/* Caution: these depend on wal_segment_size_mb, they're not constants */`
	`1283`	`+conflines=replace_guc_value(conflines,"min_wal_size",`
	`1284`	`+pretty_wal_size(DEFAULT_MIN_WAL_SEGS), false);`
	`1285`	`+`
	`1286`	`+conflines=replace_guc_value(conflines,"max_wal_size",`
	`1287`	`+pretty_wal_size(DEFAULT_MAX_WAL_SEGS), false);`
	`1288`	`+`
`1282`	`1289`	`/*`
`1283`	`1290`	`* Fix up various entries to match the true compile-time defaults. Since`
`1284`	`1291`	`* these are indeed defaults, keep the postgresql.conf lines commented.`
`@@ -1289,12 +1296,6 @@ setup_config(void)`
`1289`	`1296`	`conflines=replace_guc_value(conflines,"port",`
`1290`	`1297`	`DEF_PGPORT_STR, true);`
`1291`	`1298`
`1292`		`-conflines=replace_guc_value(conflines,"min_wal_size",`
`1293`		`-pretty_wal_size(DEFAULT_MIN_WAL_SEGS), true);`
`1294`		`-`
`1295`		`-conflines=replace_guc_value(conflines,"max_wal_size",`
`1296`		`-pretty_wal_size(DEFAULT_MAX_WAL_SEGS), true);`
`1297`		`-`
`1298`	`1299`	`#ifDEFAULT_BACKEND_FLUSH_AFTER>0`
`1299`	`1300`	`snprintf(repltok,sizeof(repltok),"%dkB",`
`1300`	`1301`	`DEFAULT_BACKEND_FLUSH_AFTER* (BLCKSZ /1024));`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb48af6d

File tree

1 file changed

1 file changed

`‎src/bin/initdb/initdb.c`

0 commit comments