Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitb43f7c1

Browse files
committed
Partially revert "Insert temporary debugging output in regression tests."
This reverts much of commitf03a9ca,but leaves the relpages/reltuples probe in select_parallel.sql.The pg_stat_all_tables probes are unstable enough to be annoying,and it no longer seems likely that they will teach us anything moreabout the underlying problem. I'd still like some more confirmationthough that the observed plan instability is caused by VACUUM leavingrelpages/reltuples as zero for one of these tables.Discussion:https://postgr.es/m/CA+hUKG+0CxrKRWRMf5ymN3gm+BECHna2B-q1w8onKBep4HasUw@mail.gmail.com
1 parentd54ceb9 commitb43f7c1

File tree

4 files changed

+0
-51
lines changed

4 files changed

+0
-51
lines changed

‎src/test/regress/expected/select_parallel.out

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -103,19 +103,6 @@ where relname like '__star' order by relname;
103103
f_star | 1 | 16
104104
(6 rows)
105105

106-
select relname, vacuum_count, analyze_count, autovacuum_count, autoanalyze_count
107-
from pg_stat_all_tables
108-
where relname like '__star' order by relname;
109-
relname | vacuum_count | analyze_count | autovacuum_count | autoanalyze_count
110-
---------+--------------+---------------+------------------+-------------------
111-
a_star | 1 | 0 | 0 | 0
112-
b_star | 1 | 0 | 0 | 0
113-
c_star | 1 | 0 | 0 | 0
114-
d_star | 1 | 0 | 0 | 0
115-
e_star | 1 | 0 | 0 | 0
116-
f_star | 1 | 0 | 0 | 0
117-
(6 rows)
118-
119106
-- Disable Parallel Append
120107
alter table a_star reset (parallel_workers);
121108
alter table b_star reset (parallel_workers);

‎src/test/regress/expected/stats.out

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -199,33 +199,6 @@ FROM prevstats AS pr;
199199
t
200200
(1 row)
201201

202-
-- Temporary hack to investigate whether extra vacuum/analyze is happening
203-
select relname, relpages, reltuples
204-
from pg_class
205-
where relname like '__star' order by relname;
206-
relname | relpages | reltuples
207-
---------+----------+-----------
208-
a_star | 1 | 3
209-
b_star | 1 | 4
210-
c_star | 1 | 4
211-
d_star | 1 | 16
212-
e_star | 1 | 7
213-
f_star | 1 | 16
214-
(6 rows)
215-
216-
select relname, vacuum_count, analyze_count, autovacuum_count, autoanalyze_count
217-
from pg_stat_all_tables
218-
where relname like '__star' order by relname;
219-
relname | vacuum_count | analyze_count | autovacuum_count | autoanalyze_count
220-
---------+--------------+---------------+------------------+-------------------
221-
a_star | 1 | 0 | 0 | 0
222-
b_star | 1 | 0 | 0 | 0
223-
c_star | 1 | 0 | 0 | 0
224-
d_star | 1 | 0 | 0 | 0
225-
e_star | 1 | 0 | 0 | 0
226-
f_star | 1 | 0 | 0 | 0
227-
(6 rows)
228-
229202
DROP TABLE trunc_stats_test, trunc_stats_test1, trunc_stats_test2, trunc_stats_test3, trunc_stats_test4;
230203
DROP TABLE prevstats;
231204
-- End of Stats Test

‎src/test/regress/sql/select_parallel.sql

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,6 @@ select round(avg(aa)), sum(aa) from a_star a3;
4040
select relname, relpages, reltuples
4141
from pg_class
4242
where relnamelike'__star'order by relname;
43-
select relname, vacuum_count, analyze_count, autovacuum_count, autoanalyze_count
44-
from pg_stat_all_tables
45-
where relnamelike'__star'order by relname;
4643

4744
-- Disable Parallel Append
4845
altertable a_star reset (parallel_workers);

‎src/test/regress/sql/stats.sql

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -174,14 +174,6 @@ SELECT st.heap_blks_read + st.heap_blks_hit >= pr.heap_blks + cl.relpages,
174174
SELECTpr.snap_ts< pg_stat_get_snapshot_timestamp()as snapshot_newer
175175
FROM prevstatsAS pr;
176176

177-
-- Temporary hack to investigate whether extra vacuum/analyze is happening
178-
select relname, relpages, reltuples
179-
from pg_class
180-
where relnamelike'__star'order by relname;
181-
select relname, vacuum_count, analyze_count, autovacuum_count, autoanalyze_count
182-
from pg_stat_all_tables
183-
where relnamelike'__star'order by relname;
184-
185177
DROPTABLE trunc_stats_test, trunc_stats_test1, trunc_stats_test2, trunc_stats_test3, trunc_stats_test4;
186178
DROPTABLE prevstats;
187179
-- End of Stats Test

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp