NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitb43bf61

committed

Tweak PQresStatus() to avoid a clang compiler warning.

The previous test for status < 0 test is in fact testing nothing if thecompiler considers an enum to be an unsigned data type. clang doesn'tlike tautologies, so do this instead.Report by Peter Geoghegan, fix as suggested by Tom Lane.

1 parent4262e61 commitb43bf61Copy full SHA for b43bf61

File tree

1 file changed

-1

lines changed

src/interfaces/libpq
- fe-exec.c

1 file changed

-1

lines changed

`‎src/interfaces/libpq/fe-exec.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2386,7 +2386,7 @@ PQresultStatus(const PGresult *res)`
`2386`	`2386`	`char*`
`2387`	`2387`	`PQresStatus(ExecStatusTypestatus)`
`2388`	`2388`	`{`
`2389`		`-if (status<0\|\|status >=sizeofpgresStatus /sizeofpgresStatus[0])`
	`2389`	`+if ((unsignedint)status >=sizeofpgresStatus /sizeofpgresStatus[0])`
`2390`	`2390`	`returnlibpq_gettext("invalid ExecStatusType code");`
`2391`	`2391`	`returnpgresStatus[status];`
`2392`	`2392`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb43bf61

File tree

1 file changed

1 file changed

`‎src/interfaces/libpq/fe-exec.c`

0 commit comments