NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitb3a47cd

committed

Suppress compiler warning about unportable pointer value.

Setting a pointer value to "0xdeadbeef" draws a warning from somecompilers, and for good reason. Be less cute and just set it to NULL.In passing make some other cosmetic adjustments nearby.Discussion:https://postgr.es/m/CAJrrPGdW3EkU-CRobvVKYf3fJuBdgWyuGeAbNzAQ4yBh+bfb_Q@mail.gmail.com

1 parent14722c6 commitb3a47cdCopy full SHA for b3a47cd

File tree

1 file changed

-4

lines changed

src/backend/replication/logical
- proto.c

1 file changed

-4

lines changed

`‎src/backend/replication/logical/proto.c`

Lines changed: 6 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ logicalrep_read_commit(StringInfo in, LogicalRepCommitData *commit_data)`
`95`	`95`	`uint8flags=pq_getmsgbyte(in);`
`96`	`96`
`97`	`97`	`if (flags!=0)`
`98`		`-elog(ERROR,"unknown flags %u in commit message",flags);`
	`98`	`+elog(ERROR,"unrecognized flags %u in commit message",flags);`
`99`	`99`
`100`	`100`	`/* read fields */`
`101`	`101`	`commit_data->commit_lsn=pq_getmsgint64(in);`
`@@ -468,7 +468,6 @@ logicalrep_read_tuple(StringInfo in, LogicalRepTupleData *tuple)`
`468`	`468`	`for (i=0;i<natts;i++)`
`469`	`469`	`{`
`470`	`470`	`charkind;`
`471`		`-intlen;`
`472`	`471`
`473`	`472`	`kind=pq_getmsgbyte(in);`
`474`	`473`
`@@ -479,10 +478,13 @@ logicalrep_read_tuple(StringInfo in, LogicalRepTupleData *tuple)`
`479`	`478`	`tuple->changed[i]= true;`
`480`	`479`	`break;`
`481`	`480`	`case'u':/* unchanged column */`
`482`		`-tuple->values[i]= (char)0xdeadbeef;/ make bad usage more obvious */`
	`481`	`+/* we don't receive the value of an unchanged column */`
	`482`	`+tuple->values[i]=NULL;`
`483`	`483`	`break;`
`484`	`484`	`case't':/* text formatted value */`
`485`	`485`	`{`
	`486`	`+intlen;`
	`487`	`+`
`486`	`488`	`tuple->changed[i]= true;`
`487`	`489`
`488`	`490`	`len=pq_getmsgint(in,4);/* read length */`
`@@ -494,7 +496,7 @@ logicalrep_read_tuple(StringInfo in, LogicalRepTupleData *tuple)`
`494`	`496`	`}`
`495`	`497`	`break;`
`496`	`498`	`default:`
`497`		`-elog(ERROR,"unknown data representation type '%c'",kind);`
	`499`	`+elog(ERROR,"unrecognized data representation type '%c'",kind);`
`498`	`500`	`}`
`499`	`501`	`}`
`500`	`502`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb3a47cd

File tree

1 file changed

1 file changed

`‎src/backend/replication/logical/proto.c`

0 commit comments