NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitb362d14

committed

Fix memory leaks in error reporting with LOG level

When loglevel is set to LOG, allocated strings used in the errormessage would leak. Fix by explicitly pfreeing them.Author: Ranier Vilela <ranier.vf@gmail.com>Reviewed-by: Daniel Gustafsson <daniel@yesql.se>Reviewed-by: Michael Paquier <michael@paquier.xyz>Discussion:https://postgr.es/m/CAEudQAqMeE0AHcOsOzZx51Z0eiFJAjhBPRFt+Bxi3ETXWen7ig@mail.gmail.com

1 parentab4d7a3 commitb362d14Copy full SHA for b362d14

File tree

2 files changed

-1

lines changed

src/backend
- archive
  - shell_archive.c
- libpq
  - be-secure-common.c

2 files changed

-1

lines changed

`‎src/backend/archive/shell_archive.c`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -125,9 +125,11 @@ shell_archive_file(ArchiveModuleState state, const char file,`
`125`	`125`	`errdetail("The failed archive command was: %s",`
`126`	`126`	`xlogarchcmd)));`
`127`	`127`	`}`
	`128`	`+pfree(xlogarchcmd);`
`128`	`129`
`129`	`130`	`return false;`
`130`	`131`	`}`
	`132`	`+pfree(xlogarchcmd);`
`131`	`133`
`132`	`134`	`elog(DEBUG1,"archived write-ahead log file \"%s\"",file);`
`133`	`135`	`return true;`

`‎src/backend/libpq/be-secure-common.c`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -85,12 +85,16 @@ run_ssl_passphrase_command(const char prompt, bool is_server_start, char buf,`
`85`	`85`	`}`
`86`	`86`	`elseif (pclose_rc!=0)`
`87`	`87`	`{`
	`88`	`+char*reason;`
	`89`	`+`
`88`	`90`	`explicit_bzero(buf,size);`
	`91`	`+reason=wait_result_to_str(pclose_rc);`
`89`	`92`	`ereport(loglevel,`
`90`	`93`	`(errcode_for_file_access(),`
`91`	`94`	`errmsg("command \"%s\" failed",`
`92`	`95`	`command),`
`93`		`-errdetail_internal("%s",wait_result_to_str(pclose_rc))));`
	`96`	`+errdetail_internal("%s",reason)));`
	`97`	`+pfree(reason);`
`94`	`98`	`gotoerror;`
`95`	`99`	`}`
`96`	`100`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb362d14

File tree

2 files changed

2 files changed

`‎src/backend/archive/shell_archive.c`

`‎src/backend/libpq/be-secure-common.c`

0 commit comments