NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitb350175

committed

Fix cosmetic blemishes involving rd_createSubid.

Remove an obsolete comment from AtEOXact_cleanup(). Restore formattingof a comment in struct RelationData, mangled by the pgindent run incommit9af4159. Back-patch to 9.5 (allsupported versions), because another fix stacks on this.

1 parentff339f4 commitb350175Copy full SHA for b350175

File tree

2 files changed

-7

lines changed

src
- backend/utils/cache
  - relcache.c
- include/utils
  - rel.h

2 files changed

-7

lines changed

`‎src/backend/utils/cache/relcache.c`

Lines changed: 1 addition & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -3031,10 +3031,7 @@ AtEOXact_cleanup(Relation relation, bool isCommit)`
`3031`	`3031`	`*`
`3032`	`3032`	`* During commit, reset the flag to zero, since we are now out of the`
`3033`	`3033`	`* creating transaction. During abort, simply delete the relcache entry`
`3034`		`- * --- it isn't interesting any longer. (NOTE: if we have forgotten the`
`3035`		`- * new-ness of a new relation due to a forced cache flush, the entry will`
`3036`		`- * get deleted anyway by shared-cache-inval processing of the aborted`
`3037`		`- * pg_class insertion.)`
	`3034`	`+ * --- it isn't interesting any longer.`
`3038`	`3035`	`*/`
`3039`	`3036`	`if (relation->rd_createSubid!=InvalidSubTransactionId)`
`3040`	`3037`	`{`

`‎src/include/utils/rel.h`

Lines changed: 8 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ typedef struct RelationData`
`64`	`64`	`* rd_replidindex) */`
`65`	`65`	`boolrd_statvalid;/* is rd_statlist valid? */`
`66`	`66`
`67`		`-/*`
	`67`	`+/*----------`
`68`	`68`	`* rd_createSubid is the ID of the highest subtransaction the rel has`
`69`	`69`	`* survived into; or zero if the rel was not created in the current top`
`70`	`70`	`* transaction. This can be now be relied on, whereas previously it could`
`@@ -74,8 +74,13 @@ typedef struct RelationData`
`74`	`74`	`* have forgotten changing it). rd_newRelfilenodeSubid can be forgotten`
`75`	`75`	`* when a relation has multiple new relfilenodes within a single`
`76`	`76`	`* transaction, with one of them occurring in a subsequently aborted`
`77`		`- * subtransaction, e.g. BEGIN; TRUNCATE t; SAVEPOINT save; TRUNCATE t;`
`78`		`- * ROLLBACK TO save; -- rd_newRelfilenode is now forgotten`
	`77`	`+ * subtransaction, e.g.`
	`78`	`+ *BEGIN;`
	`79`	`+ *TRUNCATE t;`
	`80`	`+ *SAVEPOINT save;`
	`81`	`+ *TRUNCATE t;`
	`82`	`+ *ROLLBACK TO save;`
	`83`	`+ *-- rd_newRelfilenodeSubid is now forgotten`
`79`	`84`	`*/`
`80`	`85`	`SubTransactionIdrd_createSubid;/* rel was created in current xact */`
`81`	`86`	`SubTransactionIdrd_newRelfilenodeSubid;/* new relfilenode assigned in`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb350175

File tree

2 files changed

2 files changed

`‎src/backend/utils/cache/relcache.c`

`‎src/include/utils/rel.h`

0 commit comments