Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitb31eead

Browse files
committed
Force the second argument of SUBSTRING(foo FOR bar) to be int4, to avoid
surprising results when it's some other numeric type. This doesn't solvethe generic problem of surprising implicit casts to text, but it's alow-impact way of making sure this particular case behaves sanely.Per gripe from Harald Fuchs and subsequent discussion.
1 parent19cb457 commitb31eead

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

‎src/backend/parser/gram.y

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
*
1212
*
1313
* IDENTIFICATION
14-
* $PostgreSQL: pgsql/src/backend/parser/gram.y,v 2.511 2005/09/23 22:25:25 momjian Exp $
14+
* $PostgreSQL: pgsql/src/backend/parser/gram.y,v 2.512 2005/11/13 19:11:28 tgl Exp $
1515
*
1616
* HISTORY
1717
* AUTHORDATEMAJOR EVENT
@@ -7579,9 +7579,10 @@ position_list:
75797579
* SQL9x defines a specific syntax for arguments to SUBSTRING():
75807580
* o substring(text from int for int)
75817581
* o substring(text from int) get entire string from starting point "int"
7582-
* o substring(text from pattern) get entire string matching pattern
75837582
* o substring(text for int) get first "int" characters of string
7584-
* We also want to implement generic substring functions which accept
7583+
* o substring(text from pattern) get entire string matching pattern
7584+
* o substring(text from pattern for escape) same with specified escape char
7585+
* We also want to support generic substring functions which accept
75857586
* the usual generic list of arguments. So we will accept both styles
75867587
* here, and convert the SQL9x style to the generic list for further
75877588
* processing. - thomas 2000-11-28
@@ -7593,6 +7594,7 @@ substr_list:
75937594
}
75947595
| a_expr substr_for substr_from
75957596
{
7597+
/* not legal per SQL99, but might as well allow it*/
75967598
$$ = list_make3($1,$3,$2);
75977599
}
75987600
| a_expr substr_from
@@ -7601,10 +7603,18 @@ substr_list:
76017603
}
76027604
| a_expr substr_for
76037605
{
7606+
/*
7607+
* Since there are no cases where this syntax allows
7608+
* a textual FOR value, we forcibly cast the argument
7609+
* to int4. This is a kluge to avoid surprising results
7610+
* when the argument is, say, int8. It'd be better if
7611+
* there were not an implicit cast from int8 to text ...
7612+
*/
76047613
A_Const *n = makeNode(A_Const);
76057614
n->val.type = T_Integer;
76067615
n->val.val.ival =1;
7607-
$$ = list_make3($1, (Node *)n,$2);
7616+
$$ = list_make3($1, (Node *) n,
7617+
makeTypeCast($2, SystemTypeName("int4")));
76087618
}
76097619
| expr_list
76107620
{

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp