NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitb31a9d7

committed

Suppress compiler warning about no function return value.

Compilers that don't know that ereport(ERROR) doesn't returncomplained about the new coding in scanint8() introduced bycommit101c7ee. Tweak coding to avoid the warning.Per buildfarm.

1 parentc04d35f commitb31a9d7Copy full SHA for b31a9d7

File tree

1 file changed

-9

lines changed

src/backend/utils/adt
- int8.c

1 file changed

-9

lines changed

`‎src/backend/utils/adt/int8.c`

Lines changed: 6 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -81,9 +81,7 @@ scanint8(const char str, bool errorOK, int64 result)`
`81`	`81`
`82`	`82`	`/* require at least one digit */`
`83`	`83`	`if (unlikely(!isdigit((unsignedchar)*ptr)))`
`84`		`-{`
`85`	`84`	`gotoinvalid_syntax;`
`86`		`-}`
`87`	`85`
`88`	`86`	`/* process digits */`
`89`	`87`	`while (ptr&&isdigit((unsignedchar)ptr))`
`@@ -108,26 +106,25 @@ scanint8(const char str, bool errorOK, int64 result)`
`108`	`106`	`gotoout_of_range;`
`109`	`107`	`tmp=-tmp;`
`110`	`108`	`}`
`111`		`-*result=tmp;`
`112`	`109`
	`110`	`+*result=tmp;`
`113`	`111`	`return true;`
`114`	`112`
`115`	`113`	`out_of_range:`
`116`		`-if (errorOK)`
`117`		`-return false;`
`118`		`-else`
	`114`	`+if (!errorOK)`
`119`	`115`	`ereport(ERROR,`
`120`	`116`	`(errcode(ERRCODE_NUMERIC_VALUE_OUT_OF_RANGE),`
`121`	`117`	`errmsg("value \"%s\" is out of range for type %s",`
`122`	`118`	`str,"bigint")));`
	`119`	`+return false;`
	`120`	`+`
`123`	`121`	`invalid_syntax:`
`124`		`-if (errorOK)`
`125`		`-return false;`
`126`		`-else`
	`122`	`+if (!errorOK)`
`127`	`123`	`ereport(ERROR,`
`128`	`124`	`(errcode(ERRCODE_INVALID_TEXT_REPRESENTATION),`
`129`	`125`	`errmsg("invalid input syntax for integer: \"%s\"",`
`130`	`126`	`str)));`
	`127`	`+return false;`
`131`	`128`	`}`
`132`	`129`
`133`	`130`	`/* int8in()`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb31a9d7

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/int8.c`

0 commit comments