NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitb3196e6

committed

Fix bug for array-formatted identities of user mappings

I failed to realize that server names reported in the object args arraywould get quoted, which is wrong; remove that, making sure that it'sonly quoted in the string-formatted identity.This bug was introduced by my commitcf34e37, which was backpatched,but since object name/args arrays are new in commita676201, thereis no need to backpatch this any further.

1 parentdc8e052 commitb3196e6Copy full SHA for b3196e6

File tree

1 file changed

-2

lines changed

src/backend/catalog
- objectaddress.c

1 file changed

-2

lines changed

`‎src/backend/catalog/objectaddress.c`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -4254,7 +4254,7 @@ getObjectIdentityParts(const ObjectAddress *object,`
`4254`	`4254`	`ReleaseSysCache(tup);`
`4255`	`4255`
`4256`	`4256`	`if (OidIsValid(useid))`
`4257`		`-usename=quote_identifier(GetUserNameFromId(useid));`
	`4257`	`+usename=GetUserNameFromId(useid);`
`4258`	`4258`	`else`
`4259`	`4259`	`usename="public";`
`4260`	`4260`
`@@ -4264,7 +4264,8 @@ getObjectIdentityParts(const ObjectAddress *object,`
`4264`	`4264`	`*objargs=list_make1(pstrdup(srv->servername));`
`4265`	`4265`	`}`
`4266`	`4266`
`4267`		`-appendStringInfo(&buffer,"%s on server %s",usename,`
	`4267`	`+appendStringInfo(&buffer,"%s on server %s",`
	`4268`	`+quote_identifier(usename),`
`4268`	`4269`	`srv->servername);`
`4269`	`4270`	`break;`
`4270`	`4271`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb3196e6

File tree

1 file changed

1 file changed

`‎src/backend/catalog/objectaddress.c`

0 commit comments