NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitb2ed8ed

committed

Fix bug in collecting total_latencies from all threads in pgbench.

This was broken in1bc90f7, which removed the thread-emulation. With modest-j and -c settings the result were usually close enough that you wouldn'tnotice it easily, but with a high enough thread count it would accessuninitialized memory and crash.Per report from Andres Freund offlist.

1 parent5e65f45 commitb2ed8edCopy full SHA for b2ed8ed

File tree

1 file changed

-2

lines changed

src/bin/pgbench
- pgbench.c

1 file changed

-2

lines changed

`‎src/bin/pgbench/pgbench.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -3456,8 +3456,8 @@ main(int argc, char **argv)`
`3456`	`3456`	`for (j=0;j<thread->nstate;j++)`
`3457`	`3457`	`{`
`3458`	`3458`	`total_xacts+=thread->state[j].cnt;`
`3459`		`-total_latencies+=thread->state[i].txn_latencies;`
`3460`		`-total_sqlats+=thread->state[i].txn_sqlats;`
	`3459`	`+total_latencies+=thread->state[j].txn_latencies;`
	`3460`	`+total_sqlats+=thread->state[j].txn_sqlats;`
`3461`	`3461`	`}`
`3462`	`3462`	`}`
`3463`	`3463`	`disconnect_all(state,nclients);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb2ed8ed

File tree

1 file changed

1 file changed

`‎src/bin/pgbench/pgbench.c`

0 commit comments