Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitb212245

Browse files
committed
In guc.c, ignore ERANGE errors from strtod().
Instead, just proceed with the infinity or zero result that it shouldreturn for overflow/underflow. This avoids a platform dependency,in that various versions of strtod are inconsistent about whether theysignal ERANGE for a value that's specified as infinity.It's possible this won't be enough to remove the buildfarm failureswe're seeing fromac75959, in which case I'll take out the infinitytest case that commit added. But first let's see if we can fix it.Discussion:https://postgr.es/m/E1h33xk-0001Og-Gs@gemulon.postgresql.org
1 parent08cecfa commitb212245

File tree

1 file changed

+7
-5
lines changed
  • src/backend/utils/misc

1 file changed

+7
-5
lines changed

‎src/backend/utils/misc/guc.c

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6240,13 +6240,15 @@ parse_real(const char *value, double *result, int flags, const char **hintmsg)
62406240
if (hintmsg)
62416241
*hintmsg=NULL;
62426242

6243-
errno=0;
62446243
val=strtod(value,&endptr);
6244+
if (endptr==value)
6245+
return false;/* no HINT for syntax error */
62456246

6246-
if (endptr==value||errno==ERANGE)
6247-
return false;/* no HINT for these cases */
6248-
6249-
/* reject NaN (infinities will fail range checks later) */
6247+
/*
6248+
* We ignore strtod's errno, so that out-of-range inputs will just result
6249+
* in zero or infinity values. Subsequent range checks will reject those
6250+
* if necessary. We do need to reject NaN explicitly, however.
6251+
*/
62506252
if (isnan(val))
62516253
return false;/* treat same as syntax error; no HINT */
62526254

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp