Commitb20fe54

committed

Set exit status for pgindent if pg_bsd_indent fails

Also document the exit codes in the script.The new exit code is 3, and is not overridden by the exit code set in--check mode.Author: Ashutosh BapatDiscussion:https://postgr.es/m/CAExHW5sPRSiFeLdP-u1Fa5ba7YS2f0gvLjmKOobopKadJwQ_GQ@mail.gmail.com

1 parent7b27f5f commitb20fe54Copy full SHA for b20fe54

File tree

-1

lines changed

-1

lines changed

Lines changed: 9 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,13 @@`
`2`	`2`
`3`	`3`	`# Copyright (c) 2021-2025, PostgreSQL Global Development Group`
`4`	`4`
	`5`	`+# Program to maintain uniform layout style in our C code.`
	`6`	`+# Exit codes:`
	`7`	`+# 0 -- all OK`
	`8`	`+# 1 -- error invoking pgindent, nothing done`
	`9`	`+# 2 -- --check mode and at least one file requires changes`
	`10`	`+# 3 -- pg_bsd_indent failed on at least one file`
	`11`	`+`
`5`	`12`	`use strict;`
`6`	`13`	`use warningsFATAL=>'all';`
`7`	`14`
`@@ -408,6 +415,7 @@ foreach my $source_filename (@files)`
`408`	`415`	`if ($sourceeq"")`
`409`	`416`	`{`
`410`	`417`	`printSTDERR"Failure in$source_filename:" .$error_message ."\n";`
	`418`	`+$status = 3;`
`411`	`419`	`next;`
`412`	`420`	`}`
`413`	`421`
`@@ -428,7 +436,7 @@ foreach my $source_filename (@files)`
`428`	`436`
`429`	`437`	`if ($check)`
`430`	`438`	`{`
`431`		`-$status = 2;`
	`439`	`+$status\|\|= 2;`
`432`	`440`	`lastunless$diff;`
`433`	`441`	`}`
`434`	`442`	`}`

Comments

(0)