NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitb1d6538

committed

Fix race condition when sharing tuple descriptors.

Parallel query processes that called BlessTupleDesc() for identicaltuple descriptors at the same moment could crash. There was code tohandle that rare case, but it dereferenced a bogus DSA pointer. Repair.Back-patch to 11, where commit cc5f8136 added support for sharing tupledescriptors in parallel queries.Reported-by: Eric Thinnes <e.thinnes@gmx.de>Discussion:https://postgr.es/m/99aaa2eb-e194-bf07-c29a-1a76b4f2bcf9%40gmx.de

1 parentd69fcb9 commitb1d6538Copy full SHA for b1d6538

File tree

1 file changed

-1

lines changed

src/backend/utils/cache
- typcache.c

1 file changed

-1

lines changed

`‎src/backend/utils/cache/typcache.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2822,7 +2822,7 @@ find_or_make_matching_shared_tupledesc(TupleDesc tupdesc)`
`2822`	`2822`	`Assert(record_table_entry->key.shared);`
`2823`	`2823`	`result= (TupleDesc)`
`2824`	`2824`	`dsa_get_address(CurrentSession->area,`
`2825`		`-record_table_entry->key.shared);`
	`2825`	`+record_table_entry->key.u.shared_tupdesc);`
`2826`	`2826`	`Assert(result->tdrefcount==-1);`
`2827`	`2827`
`2828`	`2828`	`returnresult;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb1d6538

File tree

1 file changed

1 file changed

`‎src/backend/utils/cache/typcache.c`

0 commit comments