NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitb1145ca

committed

Fix assorted inconsistent function declarations.

While gcc doesn't complain if you declare a function "static" and thendefine it not-static, other compilers do; and in any case the code ishighly misleading this way. Add the missing "static" keywords to acouple of recent patches. Per buildfarm member pademelon.

1 parent4e3b1e2 commitb1145caCopy full SHA for b1145ca

File tree

2 files changed

-2

lines changed

contrib/pg_upgrade
- pg_upgrade.c
src/bin/pg_resetxlog
- pg_resetxlog.c

2 files changed

-2

lines changed

`‎contrib/pg_upgrade/pg_upgrade.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -294,7 +294,7 @@ CreateRestrictedProcess(char cmd, PROCESS_INFORMATION processInfo, const char`
`294`	`294`	`}`
`295`	`295`	`#endif`
`296`	`296`
`297`		`-void`
	`297`	`+staticvoid`
`298`	`298`	`get_restricted_token(constchar*progname)`
`299`	`299`	`{`
`300`	`300`	`#ifdefWIN32`

`‎src/bin/pg_resetxlog/pg_resetxlog.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1147,7 +1147,7 @@ CreateRestrictedProcess(char cmd, PROCESS_INFORMATION processInfo, const char`
`1147`	`1147`	`}`
`1148`	`1148`	`#endif`
`1149`	`1149`
`1150`		`-void`
	`1150`	`+staticvoid`
`1151`	`1151`	`get_restricted_token(constchar*progname)`
`1152`	`1152`	`{`
`1153`	`1153`	`#ifdefWIN32`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb1145ca

File tree

2 files changed

2 files changed

`‎contrib/pg_upgrade/pg_upgrade.c`

`‎src/bin/pg_resetxlog/pg_resetxlog.c`

0 commit comments