NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitb107140

committed

Fix page modification outside of critical section in GIN

By oversight52ac6cd makes ginDeletePage() sets pd_prune_xid of page to bedeleted before entering the critical section. It appears that only versions 11and later were affected by this oversight.Backpatch-through: 11

1 parent32ca32d commitb107140Copy full SHA for b107140

File tree

1 file changed

-3

lines changed

src/backend/access/gin
- ginvacuum.c

1 file changed

-3

lines changed

`‎src/backend/access/gin/ginvacuum.c`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -153,9 +153,6 @@ ginDeletePage(GinVacuumState *gvs, BlockNumber deleteBlkno, BlockNumber leftBlkn`
`153`	`153`	`page=BufferGetPage(dBuffer);`
`154`	`154`	`rightlink=GinPageGetOpaque(page)->rightlink;`
`155`	`155`
`156`		`-/* For deleted page remember last xid which could knew its address */`
`157`		`-GinPageSetDeleteXid(page,ReadNewTransactionId());`
`158`		`-`
`159`	`156`	`/*`
`160`	`157`	`* Any insert which would have gone on the leaf block will now go to its`
`161`	`158`	`* right sibling.`
`@@ -168,6 +165,9 @@ ginDeletePage(GinVacuumState *gvs, BlockNumber deleteBlkno, BlockNumber leftBlkn`
`168`	`165`	`page=BufferGetPage(lBuffer);`
`169`	`166`	`GinPageGetOpaque(page)->rightlink=rightlink;`
`170`	`167`
	`168`	`+/* For deleted page remember last xid which could knew its address */`
	`169`	`+GinPageSetDeleteXid(page,ReadNewTransactionId());`
	`170`	`+`
`171`	`171`	`/* Delete downlink from parent */`
`172`	`172`	`parentPage=BufferGetPage(pBuffer);`
`173`	`173`	`#ifdefUSE_ASSERT_CHECKING`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb107140

File tree

1 file changed

1 file changed

`‎src/backend/access/gin/ginvacuum.c`

0 commit comments