NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitb04214f

committed

gistendscan() forgot to free so->giststate.

This oversight led to a massive memory leak --- upwards of 10KB per tuple--- during creation-time verification of an exclusion constraint based on aGIST index. In most other scenarios it'd just be a leak of 10KB that wouldbe recovered at end of query, so not too significant; though perhaps theleak would be noticeable in a situation where a GIST index was being usedin a nestloop inner indexscan. In any case, it's a real leak of longstanding, so patch all supported branches. Per report from Harald Fuchs.

1 parentcac7332 commitb04214fCopy full SHA for b04214f

File tree

1 file changed

-1

lines changed

src/backend/access/gist
- gistscan.c

1 file changed

-1

lines changed

`‎src/backend/access/gist/gistscan.c`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -138,12 +138,15 @@ gistendscan(PG_FUNCTION_ARGS)`
`138`	`138`	`{`
`139`	`139`	`gistfreestack(so->stack);`
`140`	`140`	`if (so->giststate!=NULL)`
	`141`	`+{`
`141`	`142`	`freeGISTstate(so->giststate);`
	`143`	`+pfree(so->giststate);`
	`144`	`+}`
`142`	`145`	`/* drop pins on buffers -- we aren't holding any locks */`
`143`	`146`	`if (BufferIsValid(so->curbuf))`
`144`	`147`	`ReleaseBuffer(so->curbuf);`
`145`	`148`	`MemoryContextDelete(so->tempCxt);`
`146`		`-pfree(scan->opaque);`
	`149`	`+pfree(so);`
`147`	`150`	`}`
`148`	`151`
`149`	`152`	`PG_RETURN_VOID();`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb04214f

File tree

1 file changed

1 file changed

`‎src/backend/access/gist/gistscan.c`

0 commit comments