Commitaf67aee

committed

pg_waldump: Fix small memory leak when rmgr->rm_identify returns NULL.

This got broken in604f795, shortly after rm_identify'sintroduction.Author: Andres FreundDiscussion:https://postgr.es/m/20191029233341.4gnyau7e5v2lh5sc@alap3.anarazel.deBackpatch: 9.5, where rm_identify was introduced

1 parent9f7a664 commitaf67aeeCopy full SHA for af67aee

File tree

-5

lines changed

-5

lines changed

Lines changed: 6 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -542,17 +542,18 @@ XLogDumpDisplayRecord(XLogDumpConfig config, XLogReaderState record)`
`542`	`542`
`543`	`543`	`XLogDumpRecordLen(record,&rec_len,&fpi_len);`
`544`	`544`
`545`		`-id=desc->rm_identify(info);`
`546`		`-if (id==NULL)`
`547`		`-id=psprintf("UNKNOWN (%x)",info& ~XLR_INFO_MASK);`
`548`		`-`
`549`	`545`	`printf("rmgr: %-11s len (rec/tot): %6u/%6u, tx: %10u, lsn: %X/%08X, prev %X/%08X, ",`
`550`	`546`	`desc->rm_name,`
`551`	`547`	`rec_len,XLogRecGetTotalLen(record),`
`552`	`548`	`XLogRecGetXid(record),`
`553`	`549`	`(uint32) (record->ReadRecPtr >>32), (uint32)record->ReadRecPtr,`
`554`	`550`	`(uint32) (xl_prev >>32), (uint32)xl_prev);`
`555`		`-printf("desc: %s ",id);`
	`551`	`+`
	`552`	`+id=desc->rm_identify(info);`
	`553`	`+if (id==NULL)`
	`554`	`+printf("desc: UNKNOWN (%x) ",info& ~XLR_INFO_MASK);`
	`555`	`+else`
	`556`	`+printf("desc: %s ",id);`
`556`	`557`
`557`	`558`	`/* the desc routine will printf the description directly to stdout */`
`558`	`559`	`desc->rm_desc(NULL,record);`

Comments

(0)