NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitaf38498

committed

Move hash_any prototype from access/hash.h to utils/hashutils.h

... as well as its implementation from backend/access/hash/hashfunc.c tobackend/utils/hash/hashfn.c.access/hash is the place for the hash index AM, not really appropriatefor generic facilities, which is what hash_any is; having things the oldway meant that anything using hash_any had to include the AM's includefile, pointlessly polluting its namespace with unrelated, unnecessarycruft.Also move the HTEqual strategy number to access/stratnum.h fromaccess/hash.h.To avoid breaking third-party extension code, add an #include"utils/hashutils.h" to access/hash.h. (An easily removed line bycommitters who enjoy their asbestos suits to protect them from angryextension authors.)Discussion:https://postgr.es/m/201901251935.ser5e4h6djt2@alvherre.pgsql

1 parentb212245 commitaf38498Copy full SHA for af38498

File tree

40 files changed

+690

-687

lines changed

contrib
- citext
  - citext.c
- hstore
  - hstore_op.c
- pg_stat_statements
  - pg_stat_statements.c
- sepgsql
  - uavc.c
src
- backend
  - access
    - common
      - tupdesc.c
    - hash
      - hashfunc.c
    - tablesample
      - bernoulli.c
      - system.c
  - catalog
    - pg_publication.c
  - commands
    - publicationcmds.c
  - executor
    - execGrouping.c
    - nodeSamplescan.c
  - lib
    - bloomfilter.c
  - nodes
    - bitmapset.c
  - storage/file
    - sharedfileset.c
  - tsearch
    - ts_typanalyze.c
  - utils
    - adt
    - cache
      - catcache.c
      - relcache.c
    - hash
      - hashfn.c
    - resowner
      - resowner.c
    - sort
      - tuplesort.c
- include
  - access
    - hash.h
    - stratnum.h
  - utils
    - hashutils.h

40 files changed

+690

-687

lines changed

`‎contrib/citext/citext.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3,10 +3,10 @@`
`3`	`3`	`*/`
`4`	`4`	`#include"postgres.h"`
`5`	`5`
`6`		`-#include"access/hash.h"`
`7`	`6`	`#include"catalog/pg_collation.h"`
`8`	`7`	`#include"utils/builtins.h"`
`9`	`8`	`#include"utils/formatting.h"`
	`9`	`+#include"utils/hashutils.h"`
`10`	`10`	`#include"utils/varlena.h"`
`11`	`11`
`12`	`12`	`PG_MODULE_MAGIC;`

`‎contrib/hstore/hstore_op.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3,11 +3,11 @@`
`3`	`3`	`*/`
`4`	`4`	`#include"postgres.h"`
`5`	`5`
`6`		`-#include"access/hash.h"`
`7`	`6`	`#include"access/htup_details.h"`
`8`	`7`	`#include"catalog/pg_type.h"`
`9`	`8`	`#include"funcapi.h"`
`10`	`9`	`#include"utils/builtins.h"`
	`10`	`+#include"utils/hashutils.h"`
`11`	`11`	`#include"utils/memutils.h"`
`12`	`12`
`13`	`13`	`#include"hstore.h"`

`‎contrib/pg_stat_statements/pg_stat_statements.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,6 @@`
`61`	`61`	`#include<sys/stat.h>`
`62`	`62`	`#include<unistd.h>`
`63`	`63`
`64`		`-#include"access/hash.h"`
`65`	`64`	`#include"catalog/pg_authid.h"`
`66`	`65`	`#include"executor/instrument.h"`
`67`	`66`	`#include"funcapi.h"`
`@@ -78,6 +77,7 @@`
`78`	`77`	`#include"tcop/utility.h"`
`79`	`78`	`#include"utils/acl.h"`
`80`	`79`	`#include"utils/builtins.h"`
	`80`	`+#include"utils/hashutils.h"`
`81`	`81`	`#include"utils/memutils.h"`
`82`	`82`
`83`	`83`	`PG_MODULE_MAGIC;`

`‎contrib/sepgsql/uavc.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -12,11 +12,11 @@`
`12`	`12`	`*/`
`13`	`13`	`#include"postgres.h"`
`14`	`14`
`15`		`-#include"access/hash.h"`
`16`	`15`	`#include"catalog/pg_proc.h"`
`17`	`16`	`#include"commands/seclabel.h"`
`18`	`17`	`#include"storage/ipc.h"`
`19`	`18`	`#include"utils/guc.h"`
	`19`	`+#include"utils/hashutils.h"`
`20`	`20`	`#include"utils/memutils.h"`
`21`	`21`
`22`	`22`	`#include"sepgsql.h"`

`‎src/backend/access/common/tupdesc.c`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,6 @@`
`19`	`19`
`20`	`20`	`#include"postgres.h"`
`21`	`21`
`22`		`-#include"access/hash.h"`
`23`	`22`	`#include"access/htup_details.h"`
`24`	`23`	`#include"access/tupdesc_details.h"`
`25`	`24`	`#include"catalog/pg_collation.h"`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitaf38498

File tree

40 files changed

40 files changed

`‎contrib/citext/citext.c`

`‎contrib/hstore/hstore_op.c`

`‎contrib/pg_stat_statements/pg_stat_statements.c`

`‎contrib/sepgsql/uavc.c`

`‎src/backend/access/common/tupdesc.c`

0 commit comments