Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitaf3290f

Browse files
author
Amit Kapila
committed
Change overly strict Assert in TransactionGroupUpdateXidStatus.
This Assert thought that an overflowed transaction can never get registeredfor the group update.  But that is not true, because even when the numberof children for a transaction got reduced, the overflow flag is notchanged. And, for group update, we only care about the current number ofchildren for a transaction that is being committed.Based on comments by Andres Freund, remove a redundant Assert inTransactionIdSetPageStatus as we already had a static Assert for the samecondition a few lines earlier.Reported-by: Vignesh CAuthor: Dilip KumarReviewed-by: Amit KapilaBackpatch-through: 11Discussion:https://postgr.es/m/CAFiTN-s5=uJw-Z6JC9gcqtBSjXsrHnU63PXBrA=pnBjqnkm5UA@mail.gmail.com
1 parentfcf3b69 commitaf3290f

File tree

1 file changed

+3
-10
lines changed
  • src/backend/access/transam

1 file changed

+3
-10
lines changed

‎src/backend/access/transam/clog.c

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -299,13 +299,6 @@ TransactionIdSetPageStatus(TransactionId xid, int nsubxids,
299299
memcmp(subxids,MyProc->subxids.xids,
300300
nsubxids*sizeof(TransactionId))==0)
301301
{
302-
/*
303-
* We don't try to do group update optimization if a process has
304-
* overflowed the subxids array in its PGPROC, since in that case we
305-
* don't have a complete list of XIDs for it.
306-
*/
307-
Assert(THRESHOLD_SUBTRANS_CLOG_OPT <=PGPROC_MAX_CACHED_SUBXIDS);
308-
309302
/*
310303
* If we can immediately acquire CLogControlLock, we update the status
311304
* of our own XID and release the lock. If not, try use group XID
@@ -520,10 +513,10 @@ TransactionGroupUpdateXidStatus(TransactionId xid, XidStatus status,
520513
PGXACT*pgxact=&ProcGlobal->allPgXact[nextidx];
521514

522515
/*
523-
*Overflowed transactions should not use group XID status update
524-
* mechanism.
516+
*Transactions with more than THRESHOLD_SUBTRANS_CLOG_OPT sub-XIDs
517+
*should not use group XID status updatemechanism.
525518
*/
526-
Assert(!pgxact->overflowed);
519+
Assert(pgxact->nxids <=THRESHOLD_SUBTRANS_CLOG_OPT);
527520

528521
TransactionIdSetPageStatusInternal(proc->clogGroupMemberXid,
529522
pgxact->nxids,

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp