Commitaf1022d

committed

Fix thinko in multi-autovac-workers code: validity checks made by

GUC assign hooks are supposed to be made whether doit is true or not.

1 parent849ec99 commitaf1022dCopy full SHA for af1022d

File tree

-11

lines changed

-11

lines changed

Lines changed: 7 additions & 11 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`* Written by Peter Eisentraut <peter_e@gmx.net>.`
`11`	`11`	`*`
`12`	`12`	`* IDENTIFICATION`
`13`		`- * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.410 2007/08/04 19:29:25 tgl Exp $`
	`13`	`+ * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.411 2007/08/08 16:00:46 tgl Exp $`
`14`	`14`	`*`
`15`	`15`	`*--------------------------------------------------------------------`
`16`	`16`	`*/`
`@@ -6956,27 +6956,23 @@ show_tcp_keepalives_count(void)`
`6956`	`6956`	`staticbool`
`6957`	`6957`	`assign_maxconnections(intnewval,booldoit,GucSourcesource)`
`6958`	`6958`	`{`
`6959`		`-if (doit)`
`6960`		`-{`
`6961`		`-if (newval+autovacuum_max_workers>INT_MAX /4)`
`6962`		`-return false;`
	`6959`	`+if (newval+autovacuum_max_workers>INT_MAX /4)`
	`6960`	`+return false;`
`6963`	`6961`
	`6962`	`+if (doit)`
`6964`	`6963`	`MaxBackends=newval+autovacuum_max_workers;`
`6965`		`-}`
`6966`	`6964`
`6967`	`6965`	`return true;`
`6968`	`6966`	`}`
`6969`	`6967`
`6970`	`6968`	`staticbool`
`6971`	`6969`	`assign_autovacuum_max_workers(intnewval,booldoit,GucSourcesource)`
`6972`	`6970`	`{`
`6973`		`-if (doit)`
`6974`		`-{`
`6975`		`-if (newval+MaxConnections>INT_MAX /4)`
`6976`		`-return false;`
	`6971`	`+if (newval+MaxConnections>INT_MAX /4)`
	`6972`	`+return false;`
`6977`	`6973`
	`6974`	`+if (doit)`
`6978`	`6975`	`MaxBackends=newval+MaxConnections;`
`6979`		`-}`
`6980`	`6976`
`6981`	`6977`	`return true;`
`6982`	`6978`	`}`

Comments

(0)