Commitadf7cc0

committed

Doc fix for INSERT ... (DEFAULT, ...)

Appears I forgot to update the docs earlier.Rod Taylor

1 parent9fcc115 commitadf7cc0Copy full SHA for adf7cc0

File tree

+24

-4

lines changed

+24

-4

lines changed

Lines changed: 9 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/commands/tablecmds.c,v 1.7 2002/04/22 21:56:06 tgl Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/commands/tablecmds.c,v 1.8 2002/04/24 02:38:58 momjian Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -620,8 +620,14 @@ AlterTableAlterColumnDefault(Oid myrelid,`
`620`	`620`
`621`	`621`	`rel=heap_open(myrelid,AccessExclusiveLock);`
`622`	`622`
`623`		`-if (rel->rd_rel->relkind!=RELKIND_RELATION)`
`624`		`-elog(ERROR,"ALTER TABLE: relation \"%s\" is not a table",`
	`623`	`+/*`
	`624`	`+ * We allow defaults on views so that INSERT into a view can have`
	`625`	`+ * default-ish behavior. This works because the rewriter substitutes`
	`626`	`+ * default values into INSERTs before it expands rules.`
	`627`	`+ */`
	`628`	`+if (rel->rd_rel->relkind!=RELKIND_RELATION&&`
	`629`	`+rel->rd_rel->relkind!=RELKIND_VIEW)`
	`630`	`+elog(ERROR,"ALTER TABLE: relation \"%s\" is not a table or view",`
`625`	`631`	`RelationGetRelationName(rel));`
`626`	`632`
`627`	`633`	`if (!allowSystemTableMods`

Lines changed: 15 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@`
`22`	`22`	`*`
`23`	`23`	`*`
`24`	`24`	`* IDENTIFICATION`
`25`		`- * $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.251 2002/04/21 05:21:17 petere Exp $`
	`25`	`+ * $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.252 2002/04/24 02:38:58 momjian Exp $`
`26`	`26`	`*`
`27`	`27`	`*-------------------------------------------------------------------------`
`28`	`28`	`*/`
`@@ -4368,6 +4368,20 @@ dumpTables(Archive fout, TableInfo tblinfo, int numTables,`
`4368`	`4368`	`objoid=tblinfo[i].viewoid;`
`4369`	`4369`	`appendPQExpBuffer(delq,"DROP VIEW %s;\n",fmtId(tblinfo[i].relname,force_quotes));`
`4370`	`4370`	`appendPQExpBuffer(q,"CREATE VIEW %s as %s\n",fmtId(tblinfo[i].relname,force_quotes),tblinfo[i].viewdef);`
	`4371`	`+`
	`4372`	`+/*`
	`4373`	`+ * Views can have default values -- however, they must be`
	`4374`	`+ * specified in an ALTER TABLE command after the view has`
	`4375`	`+ * been created, not in the view definition itself.`
	`4376`	`+ */`
	`4377`	`+for (j=0;j<tblinfo[i].numatts;j++)`
	`4378`	`+{`
	`4379`	`+if (tblinfo[i].adef_expr[j]!=NULL&&tblinfo[i].inhAttrDef[j]==0)`
	`4380`	`+appendPQExpBuffer(q,"ALTER TABLE %s ALTER COLUMN %s SET DEFAULT %s;\n",`
	`4381`	`+tblinfo[i].relname,tblinfo[i].attnames[j],`
	`4382`	`+tblinfo[i].adef_expr[j]);`
	`4383`	`+}`
	`4384`	`+`
`4371`	`4385`	`commentDeps=malloc(sizeof(char)2);`
`4372`	`4386`	`(*commentDeps)[0]=strdup(objoid);`
`4373`	`4387`	`(commentDeps)[1]=NULL;/ end of list */`

Comments

(0)