Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitade49c6

Browse files
committed
Test all contrib-created operator classes with amvalidate.
I'd supposed that people would do this manually when creating new operatorclasses, but the folly of that was exposed today. The tests seem fastenough that we can just apply them during the normal regression tests.contrib/isn fails the checks for lack of complete sets of cross-typeoperators. That's a nice-to-have policy rather than a functionalrequirement, so leave it as-is, but insert ORDER BY in the query toensure consistent cross-platform output.Discussion:https://postgr.es/m/7076.1480446837@sss.pgh.pa.us
1 parent11da83a commitade49c6

File tree

25 files changed

+207
-0
lines changed

25 files changed

+207
-0
lines changed
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,9 @@
11
CREATE EXTENSION btree_gin;
2+
-- Check whether any of our opclasses fail amvalidate
3+
SELECT amname, opcname
4+
FROM pg_opclass opc LEFT JOIN pg_am am ON am.oid = opcmethod
5+
WHERE opc.oid >= 16384 AND NOT amvalidate(opc.oid);
6+
amname | opcname
7+
--------+---------
8+
(0 rows)
9+
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,6 @@
11
CREATE EXTENSION btree_gin;
2+
3+
-- Check whether any of our opclasses fail amvalidate
4+
SELECT amname, opcname
5+
FROM pg_opclass opcLEFT JOIN pg_am amONam.oid= opcmethod
6+
WHEREopc.oid>=16384AND NOT amvalidate(opc.oid);

‎contrib/btree_gist/expected/init.out

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,9 @@
11
CREATE EXTENSION btree_gist;
2+
-- Check whether any of our opclasses fail amvalidate
3+
SELECT amname, opcname
4+
FROM pg_opclass opc LEFT JOIN pg_am am ON am.oid = opcmethod
5+
WHERE opc.oid >= 16384 AND NOT amvalidate(opc.oid);
6+
amname | opcname
7+
--------+---------
8+
(0 rows)
9+

‎contrib/btree_gist/sql/init.sql

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,6 @@
11
CREATE EXTENSION btree_gist;
2+
3+
-- Check whether any of our opclasses fail amvalidate
4+
SELECT amname, opcname
5+
FROM pg_opclass opcLEFT JOIN pg_am amONam.oid= opcmethod
6+
WHEREopc.oid>=16384AND NOT amvalidate(opc.oid);

‎contrib/citext/expected/citext.out

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,14 @@
22
-- Test citext datatype
33
--
44
CREATE EXTENSION citext;
5+
-- Check whether any of our opclasses fail amvalidate
6+
SELECT amname, opcname
7+
FROM pg_opclass opc LEFT JOIN pg_am am ON am.oid = opcmethod
8+
WHERE opc.oid >= 16384 AND NOT amvalidate(opc.oid);
9+
amname | opcname
10+
--------+---------
11+
(0 rows)
12+
513
-- Test the operators and indexing functions
614
-- Test = and <>.
715
SELECT 'a'::citext = 'a'::citext AS t;

‎contrib/citext/expected/citext_1.out

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,14 @@
22
-- Test citext datatype
33
--
44
CREATE EXTENSION citext;
5+
-- Check whether any of our opclasses fail amvalidate
6+
SELECT amname, opcname
7+
FROM pg_opclass opc LEFT JOIN pg_am am ON am.oid = opcmethod
8+
WHERE opc.oid >= 16384 AND NOT amvalidate(opc.oid);
9+
amname | opcname
10+
--------+---------
11+
(0 rows)
12+
513
-- Test the operators and indexing functions
614
-- Test = and <>.
715
SELECT 'a'::citext = 'a'::citext AS t;

‎contrib/citext/sql/citext.sql

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@
44

55
CREATE EXTENSION citext;
66

7+
-- Check whether any of our opclasses fail amvalidate
8+
SELECT amname, opcname
9+
FROM pg_opclass opcLEFT JOIN pg_am amONam.oid= opcmethod
10+
WHEREopc.oid>=16384AND NOT amvalidate(opc.oid);
11+
712
-- Test the operators and indexing functions
813

914
-- Test = and <>.

‎contrib/cube/expected/cube.out

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,14 @@
22
-- Test cube datatype
33
--
44
CREATE EXTENSION cube;
5+
-- Check whether any of our opclasses fail amvalidate
6+
SELECT amname, opcname
7+
FROM pg_opclass opc LEFT JOIN pg_am am ON am.oid = opcmethod
8+
WHERE opc.oid >= 16384 AND NOT amvalidate(opc.oid);
9+
amname | opcname
10+
--------+---------
11+
(0 rows)
12+
513
--
614
-- testing the input and output functions
715
--

‎contrib/cube/expected/cube_2.out

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,14 @@
22
-- Test cube datatype
33
--
44
CREATE EXTENSION cube;
5+
-- Check whether any of our opclasses fail amvalidate
6+
SELECT amname, opcname
7+
FROM pg_opclass opc LEFT JOIN pg_am am ON am.oid = opcmethod
8+
WHERE opc.oid >= 16384 AND NOT amvalidate(opc.oid);
9+
amname | opcname
10+
--------+---------
11+
(0 rows)
12+
513
--
614
-- testing the input and output functions
715
--

‎contrib/cube/sql/cube.sql

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@
44

55
CREATE EXTENSION cube;
66

7+
-- Check whether any of our opclasses fail amvalidate
8+
SELECT amname, opcname
9+
FROM pg_opclass opcLEFT JOIN pg_am amONam.oid= opcmethod
10+
WHEREopc.oid>=16384AND NOT amvalidate(opc.oid);
11+
712
--
813
-- testing the input and output functions
914
--

‎contrib/hstore/expected/hstore.out

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,12 @@
11
CREATE EXTENSION hstore;
2+
-- Check whether any of our opclasses fail amvalidate
3+
SELECT amname, opcname
4+
FROM pg_opclass opc LEFT JOIN pg_am am ON am.oid = opcmethod
5+
WHERE opc.oid >= 16384 AND NOT amvalidate(opc.oid);
6+
amname | opcname
7+
--------+---------
8+
(0 rows)
9+
210
set escape_string_warning=off;
311
--hstore;
412
select ''::hstore;

‎contrib/hstore/sql/hstore.sql

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
CREATE EXTENSION hstore;
22

3+
-- Check whether any of our opclasses fail amvalidate
4+
SELECT amname, opcname
5+
FROM pg_opclass opcLEFT JOIN pg_am amONam.oid= opcmethod
6+
WHEREopc.oid>=16384AND NOT amvalidate(opc.oid);
7+
38
set escape_string_warning=off;
49

510
--hstore;

‎contrib/intarray/expected/_int.out

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,12 @@
11
CREATE EXTENSION intarray;
2+
-- Check whether any of our opclasses fail amvalidate
3+
SELECT amname, opcname
4+
FROM pg_opclass opc LEFT JOIN pg_am am ON am.oid = opcmethod
5+
WHERE opc.oid >= 16384 AND NOT amvalidate(opc.oid);
6+
amname | opcname
7+
--------+---------
8+
(0 rows)
9+
210
SELECT intset(1234);
311
intset
412
--------

‎contrib/intarray/sql/_int.sql

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
CREATE EXTENSION intarray;
22

3+
-- Check whether any of our opclasses fail amvalidate
4+
SELECT amname, opcname
5+
FROM pg_opclass opcLEFT JOIN pg_am amONam.oid= opcmethod
6+
WHEREopc.oid>=16384AND NOT amvalidate(opc.oid);
7+
38
SELECT intset(1234);
49
SELECT icount('{1234234,234234}');
510
SELECT sort('{1234234,-30,234234}');

‎contrib/isn/expected/isn.out

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,50 @@
22
-- Test ISN extension
33
--
44
CREATE EXTENSION isn;
5+
-- Check whether any of our opclasses fail amvalidate
6+
-- ... they will, because of missing cross-type operators
7+
SELECT amname, opcname
8+
FROM (SELECT amname, opcname, opc.oid
9+
FROM pg_opclass opc LEFT JOIN pg_am am ON am.oid = opcmethod
10+
WHERE opc.oid >= 16384
11+
ORDER BY 1, 2 OFFSET 0) ss
12+
WHERE NOT amvalidate(oid);
13+
INFO: btree operator family "isn_ops" is missing cross-type operator(s)
14+
INFO: btree operator family "isn_ops" is missing cross-type operator(s)
15+
INFO: btree operator family "isn_ops" is missing cross-type operator(s)
16+
INFO: btree operator family "isn_ops" is missing cross-type operator(s)
17+
INFO: btree operator family "isn_ops" is missing cross-type operator(s)
18+
INFO: btree operator family "isn_ops" is missing cross-type operator(s)
19+
INFO: btree operator family "isn_ops" is missing cross-type operator(s)
20+
INFO: btree operator family "isn_ops" is missing cross-type operator(s)
21+
INFO: hash operator family "isn_ops" is missing cross-type operator(s)
22+
INFO: hash operator family "isn_ops" is missing cross-type operator(s)
23+
INFO: hash operator family "isn_ops" is missing cross-type operator(s)
24+
INFO: hash operator family "isn_ops" is missing cross-type operator(s)
25+
INFO: hash operator family "isn_ops" is missing cross-type operator(s)
26+
INFO: hash operator family "isn_ops" is missing cross-type operator(s)
27+
INFO: hash operator family "isn_ops" is missing cross-type operator(s)
28+
INFO: hash operator family "isn_ops" is missing cross-type operator(s)
29+
amname | opcname
30+
--------+------------
31+
btree | ean13_ops
32+
btree | isbn13_ops
33+
btree | isbn_ops
34+
btree | ismn13_ops
35+
btree | ismn_ops
36+
btree | issn13_ops
37+
btree | issn_ops
38+
btree | upc_ops
39+
hash | ean13_ops
40+
hash | isbn13_ops
41+
hash | isbn_ops
42+
hash | ismn13_ops
43+
hash | ismn_ops
44+
hash | issn13_ops
45+
hash | issn_ops
46+
hash | upc_ops
47+
(16 rows)
48+
549
--
650
-- test valid conversions
751
--

‎contrib/isn/sql/isn.sql

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,15 @@
44

55
CREATE EXTENSION isn;
66

7+
-- Check whether any of our opclasses fail amvalidate
8+
-- ... they will, because of missing cross-type operators
9+
SELECT amname, opcname
10+
FROM (SELECT amname, opcname,opc.oid
11+
FROM pg_opclass opcLEFT JOIN pg_am amONam.oid= opcmethod
12+
WHEREopc.oid>=16384
13+
ORDER BY1,2 OFFSET0) ss
14+
WHERE NOT amvalidate(oid);
15+
716
--
817
-- test valid conversions
918
--

‎contrib/ltree/expected/ltree.out

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,12 @@
11
CREATE EXTENSION ltree;
2+
-- Check whether any of our opclasses fail amvalidate
3+
SELECT amname, opcname
4+
FROM pg_opclass opc LEFT JOIN pg_am am ON am.oid = opcmethod
5+
WHERE opc.oid >= 16384 AND NOT amvalidate(opc.oid);
6+
amname | opcname
7+
--------+---------
8+
(0 rows)
9+
210
SELECT ''::ltree;
311
ltree
412
-------

‎contrib/ltree/sql/ltree.sql

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
CREATE EXTENSION ltree;
22

3+
-- Check whether any of our opclasses fail amvalidate
4+
SELECT amname, opcname
5+
FROM pg_opclass opcLEFT JOIN pg_am amONam.oid= opcmethod
6+
WHEREopc.oid>=16384AND NOT amvalidate(opc.oid);
7+
38
SELECT''::ltree;
49
SELECT'1'::ltree;
510
SELECT'1.2'::ltree;

‎contrib/pg_trgm/expected/pg_trgm.out

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,12 @@
11
CREATE EXTENSION pg_trgm;
2+
-- Check whether any of our opclasses fail amvalidate
3+
SELECT amname, opcname
4+
FROM pg_opclass opc LEFT JOIN pg_am am ON am.oid = opcmethod
5+
WHERE opc.oid >= 16384 AND NOT amvalidate(opc.oid);
6+
amname | opcname
7+
--------+---------
8+
(0 rows)
9+
210
select show_trgm('');
311
show_trgm
412
-----------

‎contrib/pg_trgm/sql/pg_trgm.sql

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
CREATE EXTENSION pg_trgm;
22

3+
-- Check whether any of our opclasses fail amvalidate
4+
SELECT amname, opcname
5+
FROM pg_opclass opcLEFT JOIN pg_am amONam.oid= opcmethod
6+
WHEREopc.oid>=16384AND NOT amvalidate(opc.oid);
7+
38
select show_trgm('');
49
select show_trgm('(*&^$@%@');
510
select show_trgm('a b c');

‎contrib/seg/expected/seg.out

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,14 @@
22
-- Test seg datatype
33
--
44
CREATE EXTENSION seg;
5+
-- Check whether any of our opclasses fail amvalidate
6+
SELECT amname, opcname
7+
FROM pg_opclass opc LEFT JOIN pg_am am ON am.oid = opcmethod
8+
WHERE opc.oid >= 16384 AND NOT amvalidate(opc.oid);
9+
amname | opcname
10+
--------+---------
11+
(0 rows)
12+
513
--
614
-- testing the input and output functions
715
--

‎contrib/seg/expected/seg_1.out

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,14 @@
22
-- Test seg datatype
33
--
44
CREATE EXTENSION seg;
5+
-- Check whether any of our opclasses fail amvalidate
6+
SELECT amname, opcname
7+
FROM pg_opclass opc LEFT JOIN pg_am am ON am.oid = opcmethod
8+
WHERE opc.oid >= 16384 AND NOT amvalidate(opc.oid);
9+
amname | opcname
10+
--------+---------
11+
(0 rows)
12+
513
--
614
-- testing the input and output functions
715
--

‎contrib/seg/sql/seg.sql

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,11 @@
44

55
CREATE EXTENSION seg;
66

7+
-- Check whether any of our opclasses fail amvalidate
8+
SELECT amname, opcname
9+
FROM pg_opclass opcLEFT JOIN pg_am amONam.oid= opcmethod
10+
WHEREopc.oid>=16384AND NOT amvalidate(opc.oid);
11+
712
--
813
-- testing the input and output functions
914
--

‎contrib/tsearch2/expected/tsearch2.out

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,12 @@
11
CREATE EXTENSION tsearch2;
2+
-- Check whether any of our opclasses fail amvalidate
3+
SELECT amname, opcname
4+
FROM pg_opclass opc LEFT JOIN pg_am am ON am.oid = opcmethod
5+
WHERE opc.oid >= 16384 AND NOT amvalidate(opc.oid);
6+
amname | opcname
7+
--------+---------
8+
(0 rows)
9+
210
--tsvector
311
SELECT '1'::tsvector;
412
tsvector

‎contrib/tsearch2/sql/tsearch2.sql

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
CREATE EXTENSION tsearch2;
22

3+
-- Check whether any of our opclasses fail amvalidate
4+
SELECT amname, opcname
5+
FROM pg_opclass opcLEFT JOIN pg_am amONam.oid= opcmethod
6+
WHEREopc.oid>=16384AND NOT amvalidate(opc.oid);
7+
38
--tsvector
49
SELECT'1'::tsvector;
510
SELECT'1'::tsvector;

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp