NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitade2159

committed

Add regression tests for ALTER MATERIALIZED VIEW with tablespaces

The clauses SET TABLESPACE and ALL IN TABLESPACE are supported in ALTERMATERIALIZED VIEW for a long time, and they behave mostly like ALTERTABLE by reusing the same code paths, but there were zero tests forthem. This commit closes the gap with new tests in tablespace.sql.Author: Yugo NagataDiscussion:https://postgr.es/m/20220316133337.5dc9740abfa24c25ec9f67f5@sraoss.co.jp

1 parent9616da3 commitade2159Copy full SHA for ade2159

File tree

2 files changed

+23

-1

lines changed

src/test/regress
- expected
  - tablespace.out
- sql
  - tablespace.sql

2 files changed

+23

-1

lines changed

`‎src/test/regress/expected/tablespace.out‎`

Lines changed: 15 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -905,6 +905,16 @@ SELECT COUNT(*) FROM testschema.atable;-- checks heap`
`905`	`905`	`3`
`906`	`906`	`(1 row)`
`907`	`907`
	`908`	`+-- let's try moving a materialized view from one place to another`
	`909`	`+CREATE MATERIALIZED VIEW testschema.amv AS SELECT * FROM testschema.atable;`
	`910`	`+ALTER MATERIALIZED VIEW testschema.amv SET TABLESPACE regress_tblspace;`
	`911`	`+REFRESH MATERIALIZED VIEW testschema.amv;`
	`912`	`+SELECT COUNT(*) FROM testschema.amv;`
	`913`	`+ count`
	`914`	`+-------`
	`915`	`+ 3`
	`916`	`+(1 row)`
	`917`	`+`
`908`	`918`	`-- Will fail with bad path`
`909`	`919`	`CREATE TABLESPACE regress_badspace LOCATION '/no/such/location';`
`910`	`920`	`ERROR: directory "/no/such/location" does not exist`
`@@ -939,18 +949,22 @@ RESET ROLE;`
`939`	`949`	`ALTER TABLESPACE regress_tblspace RENAME TO regress_tblspace_renamed;`
`940`	`950`	`ALTER TABLE ALL IN TABLESPACE regress_tblspace_renamed SET TABLESPACE pg_default;`
`941`	`951`	`ALTER INDEX ALL IN TABLESPACE regress_tblspace_renamed SET TABLESPACE pg_default;`
	`952`	`+ALTER MATERIALIZED VIEW ALL IN TABLESPACE regress_tblspace_renamed SET TABLESPACE pg_default;`
`942`	`953`	`-- Should show notice that nothing was done`
`943`	`954`	`ALTER TABLE ALL IN TABLESPACE regress_tblspace_renamed SET TABLESPACE pg_default;`
`944`	`955`	`NOTICE: no matching relations in tablespace "regress_tblspace_renamed" found`
	`956`	`+ALTER MATERIALIZED VIEW ALL IN TABLESPACE regress_tblspace_renamed SET TABLESPACE pg_default;`
	`957`	`+NOTICE: no matching relations in tablespace "regress_tblspace_renamed" found`
`945`	`958`	`-- Should succeed`
`946`	`959`	`DROP TABLESPACE regress_tblspace_renamed;`
`947`	`960`	`DROP SCHEMA testschema CASCADE;`
`948`		`-NOTICE: drop cascades to6 other objects`
	`961`	`+NOTICE: drop cascades to7 other objects`
`949`	`962`	`DETAIL: drop cascades to table testschema.foo`
`950`	`963`	`drop cascades to table testschema.asselect`
`951`	`964`	`drop cascades to table testschema.asexecute`
`952`	`965`	`drop cascades to table testschema.part`
`953`	`966`	`drop cascades to table testschema.atable`
	`967`	`+drop cascades to materialized view testschema.amv`
`954`	`968`	`drop cascades to table testschema.tablespace_acl`
`955`	`969`	`DROP ROLE regress_tablespace_user1;`
`956`	`970`	`DROP ROLE regress_tablespace_user2;`

`‎src/test/regress/sql/tablespace.sql‎`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -380,6 +380,12 @@ INSERT INTO testschema.atable VALUES(3);-- ok`
`380`	`380`	`INSERT INTOtestschema.atableVALUES(1);-- fail (checks index)`
`381`	`381`	`SELECTCOUNT(*)FROMtestschema.atable;-- checks heap`
`382`	`382`
	`383`	`+-- let's try moving a materialized view from one place to another`
	`384`	`+CREATE MATERIALIZED VIEWtestschema.amvASSELECT*FROMtestschema.atable;`
	`385`	`+ALTER MATERIALIZED VIEWtestschema.amvSET TABLESPACE regress_tblspace;`
	`386`	`+REFRESH MATERIALIZED VIEWtestschema.amv;`
	`387`	`+SELECTCOUNT(*)FROMtestschema.amv;`
	`388`	`+`
`383`	`389`	`-- Will fail with bad path`
`384`	`390`	`CREATETABLESPACEregress_badspace LOCATION'/no/such/location';`
`385`	`391`
`@@ -414,9 +420,11 @@ ALTER TABLESPACE regress_tblspace RENAME TO regress_tblspace_renamed;`
`414`	`420`
`415`	`421`	`ALTERTABLE ALLIN TABLESPACE regress_tblspace_renamedSET TABLESPACE pg_default;`
`416`	`422`	`ALTERINDEX ALLIN TABLESPACE regress_tblspace_renamedSET TABLESPACE pg_default;`
	`423`	`+ALTER MATERIALIZED VIEW ALLIN TABLESPACE regress_tblspace_renamedSET TABLESPACE pg_default;`
`417`	`424`
`418`	`425`	`-- Should show notice that nothing was done`
`419`	`426`	`ALTERTABLE ALLIN TABLESPACE regress_tblspace_renamedSET TABLESPACE pg_default;`
	`427`	`+ALTER MATERIALIZED VIEW ALLIN TABLESPACE regress_tblspace_renamedSET TABLESPACE pg_default;`
`420`	`428`
`421`	`429`	`-- Should succeed`
`422`	`430`	`DROPTABLESPACE regress_tblspace_renamed;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitade2159

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/tablespace.out‎`

`‎src/test/regress/sql/tablespace.sql‎`

0 commit comments