Commitad8ebcf

committed

Add HINT for restartpoint race with KeepFileRestoredFromArchive().

The five commits ending atcc2c7d6closed this race condition for v15+. For v14 through v10, add a HINT todiscourage studying the cosmetic problem.Reviewed by Kyotaro Horiguchi and David Steele.Discussion:https://postgr.es/m/20220731061747.GA3692882@rfd.leadboat.com

1 parentd2a7462 commitad8ebcfCopy full SHA for ad8ebcf

File tree

+12

-3

lines changed

+12

-3

lines changed

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3436,7 +3436,10 @@ XLogFileInit(XLogSegNo logsegno, bool *use_existent, bool use_lock)`
`3436`	`3436`	`if (fd<0)`
`3437`	`3437`	`ereport(ERROR,`
`3438`	`3438`	`(errcode_for_file_access(),`
`3439`		`-errmsg("could not open file \"%s\": %m",path)));`
	`3439`	`+errmsg("could not open file \"%s\": %m",path),`
	`3440`	`+ (AmCheckpointerProcess() ?`
	`3441`	`+errhint("This is known to fail occasionally during archive recovery, where it is harmless.") :`
	`3442`	`+0)));`
`3440`	`3443`
`3441`	`3444`	`elog(DEBUG2,"done creating and filling new WAL file");`
`3442`	`3445`

Lines changed: 8 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -800,7 +800,10 @@ durable_rename_excl(const char oldfile, const char newfile, int elevel)`
`800`	`800`	`ereport(elevel,`
`801`	`801`	`(errcode_for_file_access(),`
`802`	`802`	`errmsg("could not link file \"%s\" to \"%s\": %m",`
`803`		`-oldfile,newfile)));`
	`803`	`+oldfile,newfile),`
	`804`	`+ (AmCheckpointerProcess() ?`
	`805`	`+errhint("This is known to fail occasionally during archive recovery, where it is harmless.") :`
	`806`	`+0)));`
`804`	`807`	`return-1;`
`805`	`808`	`}`
`806`	`809`	`unlink(oldfile);`
`@@ -810,7 +813,10 @@ durable_rename_excl(const char oldfile, const char newfile, int elevel)`
`810`	`813`	`ereport(elevel,`
`811`	`814`	`(errcode_for_file_access(),`
`812`	`815`	`errmsg("could not rename file \"%s\" to \"%s\": %m",`
`813`		`-oldfile,newfile)));`
	`816`	`+oldfile,newfile),`
	`817`	`+ (AmCheckpointerProcess() ?`
	`818`	`+errhint("This is known to fail occasionally during archive recovery, where it is harmless.") :`
	`819`	`+0)));`
`814`	`820`	`return-1;`
`815`	`821`	`}`
`816`	`822`	`#endif`

Comments

(0)