Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitacc63ef

Browse files
committed
Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions.
The current use always releases this locktag. A planned use willcontinue that intent. It will involve more areas of code, making unlockomissions easier. Warn under debug_assertions, like we do for variousresource leaks. Back-patch to v12 (all supported versions), the planfor the commit of the new use.Reviewed by Heikki Linnakangas.Discussion:https://postgr.es/m/20240512232923.aa.nmisch@google.com
1 parentf663f4d commitacc63ef

File tree

1 file changed

+10
-0
lines changed
  • src/backend/storage/lmgr

1 file changed

+10
-0
lines changed

‎src/backend/storage/lmgr/lock.c

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2251,6 +2251,16 @@ LockReleaseAll(LOCKMETHODID lockmethodid, bool allLocks)
22512251
locallock->numLockOwners=0;
22522252
}
22532253

2254+
#ifdefUSE_ASSERT_CHECKING
2255+
2256+
/*
2257+
* Tuple locks are currently held only for short durations within a
2258+
* transaction. Check that we didn't forget to release one.
2259+
*/
2260+
if (LOCALLOCK_LOCKTAG(*locallock)==LOCKTAG_TUPLE&& !allLocks)
2261+
elog(WARNING,"tuple lock held at commit");
2262+
#endif
2263+
22542264
/*
22552265
* If the lock or proclock pointers are NULL, this lock was taken via
22562266
* the relation fast-path (and is not known to have been transferred).

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp