Commitac7009a

committed

pg_upgrade: fix one-byte per empty db memory leak

Report by Tatsuo Ishii, Coverity

1 parentc4fda14 commitac7009aCopy full SHA for ac7009a

File tree

-4

lines changed

-4

lines changed

Lines changed: 2 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -110,10 +110,8 @@ transfer_all_new_dbs(DbInfoArr old_db_arr, DbInfoArr new_db_arr,`
`110`	`110`	`pg_fatal("old database \"%s\" not found in the new cluster\n",`
`111`	`111`	`old_db->db_name);`
`112`	`112`
`113`		`-n_maps=0;`
`114`	`113`	`mappings=gen_db_file_maps(old_db,new_db,&n_maps,old_pgdata,`
`115`	`114`	`new_pgdata);`
`116`		`-`
`117`	`115`	`if (n_maps)`
`118`	`116`	`{`
`119`	`117`	`print_maps(mappings,n_maps,new_db->db_name);`
`@@ -123,9 +121,9 @@ transfer_all_new_dbs(DbInfoArr old_db_arr, DbInfoArr new_db_arr,`
`123`	`121`	`#endif`
`124`	`122`	`transfer_single_new_db(pageConverter,mappings,n_maps,`
`125`	`123`	`old_tablespace);`
`126`		`-`
`127`		`-pg_free(mappings);`
`128`	`124`	`}`
	`125`	`+/* We allocate something even for n_maps == 0 */`
	`126`	`+pg_free(mappings);`
`129`	`127`	`}`
`130`	`128`
`131`	`129`	`return;`

Comments

(0)