Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitac673a1

Browse files
committed
Avoid useless allocations for information of dumpable objects in pg_dump/
If there are no objects of a certain type, there is no need to do anallocation for a set of DumpableObject items. The previous coding didan allocation of 1 byte instead as per the fallback of pg_malloc() inthe event of an allocation size of zero. This assigns NULL instead fora set of dumpable objects.A similar rule already applied to findObjectByOid(), so this makes thecode more defensive as we would just fail with a pointer dereferenceinstead of attempting to use some incorrect data if a non-existing,positive, OID is given by a caller of this function.Author: Daniel GustafssonReviewed-by: Julien Rouhaud, Ranier VilelaDiscussion:https://postgr.es/m/26C43E58-BDD0-4F1A-97CC-4A07B52E32C5@yesql.se
1 parent19f5a37 commitac673a1

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

‎src/bin/pg_dump/common.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -719,6 +719,9 @@ buildIndexArray(void *objArray, int numObjs, Size objSize)
719719
DumpableObject**ptrs;
720720
inti;
721721

722+
if (numObjs <=0)
723+
returnNULL;
724+
722725
ptrs= (DumpableObject**)pg_malloc(numObjs*sizeof(DumpableObject*));
723726
for (i=0;i<numObjs;i++)
724727
ptrs[i]= (DumpableObject*) ((char*)objArray+i*objSize);

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp