NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitac50f84

committed

Fix misuse of TextDatumGetCString().

"TextDatumGetCString(PG_GETARG_TEXT_P(x))" is formally wrong: a text*is not a Datum. Although this coding will accidentally fail to fail onall known platforms, it risks leaking memory if a detoast step is needed,unlike "TextDatumGetCString(PG_GETARG_DATUM(x))" which is what's usedelsewhere. Make pg_get_object_address() fall in line with other uses.Noted while reviewing two-arg current_setting() patch.

1 parent10fb48d commitac50f84Copy full SHA for ac50f84

File tree

1 file changed

-1

lines changed

src/backend/catalog
- objectaddress.c

1 file changed

-1

lines changed

`‎src/backend/catalog/objectaddress.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1831,7 +1831,7 @@ textarray_to_strvaluelist(ArrayType *arr)`
`1831`	`1831`	`Datum`
`1832`	`1832`	`pg_get_object_address(PG_FUNCTION_ARGS)`
`1833`	`1833`	`{`
`1834`		`-char*ttype=TextDatumGetCString(PG_GETARG_TEXT_P(0));`
	`1834`	`+char*ttype=TextDatumGetCString(PG_GETARG_DATUM(0));`
`1835`	`1835`	`ArrayType*namearr=PG_GETARG_ARRAYTYPE_P(1);`
`1836`	`1836`	`ArrayType*argsarr=PG_GETARG_ARRAYTYPE_P(2);`
`1837`	`1837`	`intitype;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitac50f84

File tree

1 file changed

1 file changed

`‎src/backend/catalog/objectaddress.c`

0 commit comments