NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commitabfd009

committed

pg_dump: Strict names with no matching schema

When using pg_dump --strict-names and a schema pattern which doesn'tmatch any schemas (eg: --schema='nonexistant*'), we were incorrectlythrowing an error claiming no tables were found when, really, therewere no schemas found: -> pg_dump --strict-names --schema='nonexistant*' pg_dump: no matching tables were found for pattern "nonexistant*"Fix that by changing the error message to say 'schemas' instead, sincethat is what we are actually complaining about.Noticed while testing pg_dump error cases.Back-patch to 9.6 where --strict-names and this error message wereintroduced.

1 parent42f50cb commitabfd009Copy full SHA for abfd009

File tree

1 file changed

-1

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

-1

lines changed

`‎src/bin/pg_dump/pg_dump.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1216,7 +1216,7 @@ expand_schema_name_patterns(Archive *fout,`
`1216`	`1216`
`1217`	`1217`	`res = ExecuteSqlQuery(fout, query->data, PGRES_TUPLES_OK);`
`1218`	`1218`	`if (strict_names && PQntuples(res) == 0)`
`1219`		`-exit_horribly(NULL, "no matchingtables were found for pattern \"%s\"\n", cell->val);`
	`1219`	`+exit_horribly(NULL, "no matchingschemas were found for pattern \"%s\"\n", cell->val);`
`1220`	`1220`
`1221`	`1221`	`for (i = 0; i < PQntuples(res); i++)`
`1222`	`1222`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitabfd009

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c`

0 commit comments